Steps: - Create any template on Tools > Manage MARC modification templates - Go to Tools > Batch record modification - Apply modification to any biblionumber you choose. Result: The process removes frameworkcode, so Default framework is use. On MySQL table the column for eg changes from frameworkcode="BKS" to frameworkcode="".
This a major one and blocker for the 3.22 release.
Actually it's in 3.20.x already, so raising again the severity. Lost of data possible!
Ccing Chris as 3.20.x RM
Created attachment 44849 [details] [review] Bug 14795: Prevent modifying a record without using the original framework The origin framework is not passed on modifying the records and so the default one is used. This can caused data lost. Test plan: - Create a bibliographic record and specify a framework (not the default one). - Use the Batch records modification tools to modify it. => Without this patch, the default framework (framework code "") is used and can deteriorate the record => With this patch, the record is saved using the original framework
Created attachment 44856 [details] [review] [SIGNED-OFF] Bug 14795: Prevent modifying a record without using the original framework The origin framework is not passed on modifying the records and so the default one is used. This can caused data lost. Test plan: - Create a bibliographic record and specify a framework (not the default one). - Use the Batch records modification tools to modify it. => Without this patch, the default framework (framework code "") is used and can deteriorate the record => With this patch, the record is saved using the original framework Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested framework is lost using tool without patch Problem gone with patch No qa errors
Created attachment 44868 [details] [review] [PASSED QA] Bug 14795: Prevent modifying a record without using the original framework The origin framework is not passed on modifying the records and so the default one is used. This can caused data lost. Test plan: - Create a bibliographic record and specify a framework (not the default one). - Use the Batch records modification tools to modify it. => Without this patch, the default framework (framework code "") is used and can deteriorate the record => With this patch, the record is saved using the original framework Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested framework is lost using tool without patch Problem gone with patch No qa errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Jonathan!
This patch has been pushed to 3.20.x, will be in 3.20.6.