Bug 14810 - Improve messages in patron anonymizing tool
Summary: Improve messages in patron anonymizing tool
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Briana Greally
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2015-09-13 15:08 UTC by Katrin Fischer
Modified: 2017-01-10 19:31 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 14810 Improve messages in patron anonymizing tool (1.37 KB, patch)
2016-01-19 01:27 UTC, Briana Greally
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 14810 Improve messages in patron anonymizing tool (1.47 KB, patch)
2016-01-19 15:53 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 14810 Improve messages in patron anonymizing tool (1.49 KB, patch)
2016-01-19 17:13 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2015-09-13 15:08:29 UTC
When successfully anonymizing circulation histories up to a specific date, the tool reports:

"All patrons with checkouts older than 18/04/2015 have been anonymized"

But... we are not anonymizing the patrons, but only their checkouts :)
Comment 1 Katrin Fischer 2016-01-17 23:58:26 UTC
Some nice rewording would be good!
Comment 2 Briana Greally 2016-01-19 01:27:03 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2016-01-19 15:53:05 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2016-01-19 17:13:08 UTC
Created attachment 46913 [details] [review]
Bug 14810 Improve messages in patron anonymizing tool

To test:
Create circulation records
Go to 'http://localhost:8081/cgi-bin/koha/tools/cleanborrowers.pl'
Anonymize patron checkout history
Message should read 'All checkouts older than [date] have been
 anonymized
When patch is not applied, message reads 'All patrons with checkouts
 older than [date]  have been anonymized"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Brendan Gallagher 2016-01-27 04:30:40 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 6 Julian Maurice 2016-01-29 14:06:08 UTC
Patch pushed to 3.22.x, will be in 3.22.3
Comment 7 Frédéric Demians 2016-02-12 06:40:06 UTC
This patch has been pushed to 3.20.x, will be in 3.20.9.