Created attachment 45330 [details] [review] Bug 15282 - Switch default CHECKIN notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Update your CHECKIN notice to match the following: The following items have been checked in: ---- [% biblio.title %] ---- Thank you. 3) Generate a CHECKIN notice for a patron 4) Note there is no change to the generated notice
Created attachment 47400 [details] [review] Bug 15282 - Switch default CHECKIN notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Update your CHECKIN notice to match the following: The following items have been checked in: ---- [% biblio.title %] ---- Thank you. 3) Generate a CHECKIN notice for a patron 4) Note there is no change to the generated notice Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Blocked by bug 14757.
Created attachment 57174 [details] [review] [SIGNED-OFF] Bug 15282 - Switch default CHECKIN notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Update your CHECKIN notice to match the following: The following items have been checked in: ---- [% biblio.title %] ---- Thank you. 3) Generate a CHECKIN notice for a patron 4) Note there is no change to the generated notice Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 59615 [details] [review] Bug 15282 - Switch default CHECKIN notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Update your CHECKIN notice to match the following: The following items have been checked in: ---- [% biblio.title %] ---- Thank you. 3) Generate a CHECKIN notice for a patron 4) Note there is no change to the generated notice Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
I think that this patch should not be pushed before bug 17964.
Waiting a bit before marking the TT syntax as default.
Dependency doesn't apply. Moving to PDA.
Created attachment 79866 [details] [review] Bug 15282 - Switch default CHECKIN notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Update your CHECKIN notice to match the following: The following items have been checked in: ---- [% biblio.title %] ---- Thank you. 3) Generate a CHECKIN notice for a patron 4) Note there is no change to the generated notice Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 79898 [details] [review] Bug 15282: Switch default CHECKIN notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Update your CHECKIN notice to match the following: The following items have been checked in: ---- [% biblio.title %] ---- Thank you. 3) Generate a CHECKIN notice for a patron 4) Note there is no change to the generated notice Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 18.11
Enhancement will not be backported to 18.05.x series.