Bug 15558 - To rename the patron expiration date field in patron screen
Summary: To rename the patron expiration date field in patron screen
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: 3.22
Hardware: All All
: P5 - low normal (vote)
Assignee: Chloe Alabaster
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-12 13:19 UTC by Suresh Kumar
Modified: 2019-06-12 12:15 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15558 - To rename the patron expiration date field in patron screen (3.84 KB, patch)
2016-01-21 02:20 UTC, Chloe Alabaster
Details | Diff | Splinter Review
Bug 15558 - To rename the patron expiration date field in patron screen (3.83 KB, patch)
2016-01-21 07:57 UTC, Mirko Tietgen
Details | Diff | Splinter Review
Bug 15558 - To rename the patron expiration date field in patron screen (3.88 KB, patch)
2016-01-21 08:03 UTC, Mirko Tietgen
Details | Diff | Splinter Review
Bug 15558: [alternate] Add classes to allow for changing expiration date wording (4.10 KB, patch)
2019-06-12 12:01 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Suresh Kumar 2016-01-12 13:19:58 UTC
Hi team,

Is it possible to rename the field "Expiration date:" in patron screen with a better word. 

Regards
Suresh Kumar
Comment 1 Chloe Alabaster 2016-01-21 02:20:35 UTC Comment hidden (obsolete)
Comment 2 Mirko Tietgen 2016-01-21 07:57:37 UTC Comment hidden (obsolete)
Comment 3 Mirko Tietgen 2016-01-21 08:03:51 UTC
Created attachment 47083 [details] [review]
Bug 15558 - To rename the patron expiration date field in patron screen

To Test:
1- confirm that all places where "Expiration Date" for a patrons memebership ending now say "Renewal due"

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Comment 4 Mirko Tietgen 2016-01-21 08:06:46 UTC
Hi Chloe, your patch works for me and fixes what the bug reporter described.
Comment 5 Suresh Kumar 2016-01-21 14:01:09 UTC
Thank you very much. 

This is really helpful.
Comment 6 Owen Leonard 2016-01-21 14:44:32 UTC
I think that this change either goes too far or doesn't go far enough.

I don't see the need for this change. I think it's clear in the context of patron records what the word means. I also don't think this kind of global terminology change should be made on the basis of one suggestion. I think we need to get more opinions.

If consensus is reached, then the change should be made in a more comprehensive way. The use of the word "expire" in reference to patron accounts is broader than just labels. There are instances throughout the interface where descriptions use variations:

"You can decide if this patron category is blocked from performing actions in the OPAC if their card is expired"

"If your patron cards expire (based on your patron category settings)..."

"[ patron name ]'s account has expired..."

"...you cannot place holds because your library card has expired..."

Translators: Is there an internationalization issue here? In Koha's English translation the term "expire" can refer to a patron account, a hold, a list invitation, a news item, a self-checkout session, and a subscription.
Comment 7 Katrin Fischer 2016-01-21 15:33:36 UTC
I think in German Ablauf/ablaufen etc. would work for all of those. 
Could 'Renewal due' in English be misunderstood as the date for renewing your items? We also use Renewal in a lot of contexts, I can think of issues, subscriptions and patron accounts.
Comment 8 Marc Véron 2016-01-21 15:48:06 UTC
Question (as a non native speaker):
What is the main reason to change 'Expiration date:'?
Comment 9 Nick Clemens 2019-06-12 12:01:45 UTC
Created attachment 90529 [details] [review]
Bug 15558: [alternate] Add classes to allow for changing expiration date wording

This patch adds classes to display of 'Expiration date' so users can reword via JS
if the current phrasing does not work for them.
Comment 10 Owen Leonard 2019-06-12 12:15:11 UTC
I think that even though it is not visible in the interface, using "member" instead of "patron" in this patch is contrary to terminology guidelines.

I think this patch also misses an instance in the patron edit form: It doesn't add the new class to the label in the case that expiration date is mandatory.