Bug 15603 - Accessibility: Can't tab to select link in budgets add user popup
Summary: Accessibility: Can't tab to select link in budgets add user popup
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: natasha
QA Contact: Testopia
URL: /cgi-bin/koha/admin/add_user_search.pl
Keywords: Academy
: 15604 (view as bug list)
Depends on: 14193
Blocks: 15604 15605
  Show dependency treegraph
 
Reported: 2016-01-19 16:59 UTC by Owen Leonard
Modified: 2017-01-10 19:36 UTC (History)
11 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15603 - Accessibility: Can't tab to select link in budgets add user popup To Test - 1. If you don't have a budget and a fund, make at least one of each. 2. Go to funds from budgets. 3. Either make a new fund or edit an existing one and then click Edit (2.11 KB, patch)
2016-01-20 01:31 UTC, natasha
Details | Diff | Splinter Review
Bug 15603 - Accessibility: Can't tab to select link in budgets add user popup (2.10 KB, patch)
2016-01-20 01:33 UTC, natasha
Details | Diff | Splinter Review
Bug 15603 - Accessibility: Can't tab to select link in budgets add user popup (2.15 KB, patch)
2016-01-21 08:36 UTC, Mirko Tietgen
Details | Diff | Splinter Review
[PASSED QA] Bug 15603 - Accessibility: Can't tab to select link in budgets add user popup (2.22 KB, patch)
2016-01-22 11:33 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-01-19 16:59:59 UTC
When editing a budget, owners or users are selected from a popup window which lets you search existing patrons. In this popup window it is not possible to use the tab key to highlight the "Select" link. I assume this is because, like the problem in Bug 15602, the link has no href attribute.
Comment 1 natasha 2016-01-20 01:31:52 UTC Comment hidden (obsolete)
Comment 2 natasha 2016-01-20 01:33:44 UTC Comment hidden (obsolete)
Comment 3 natasha 2016-01-20 01:48:22 UTC
Just noticed we created another bug, don't test this patch yet.
Comment 4 natasha 2016-01-20 01:55:15 UTC
our mistake, you need to apply the patch from bug 14193 before this patch.
Comment 5 Aleisha Amohia 2016-01-21 01:34:50 UTC
*** Bug 15604 has been marked as a duplicate of this bug. ***
Comment 6 Mirko Tietgen 2016-01-21 08:36:13 UTC Comment hidden (obsolete)
Comment 7 Mirko Tietgen 2016-01-21 08:39:27 UTC
Hi Natasha, I followed your test plan, and with bug 14193 applied before, it works as expected.
Comment 8 Katrin Fischer 2016-01-22 11:33:22 UTC
Created attachment 47175 [details] [review]
[PASSED QA] Bug 15603 - Accessibility: Can't tab to select link in budgets add user popup

To Test -
1. If you don't have a budget and a fund, make at least one of each.
2. Go to funds from budgets.
3. Either make a new fund or edit an existing one and then click Edit owner, which will bring up a pop-up tab.
4. Search for a patron.
5. Using the tab key try to navigate onto the Select link.
6. Notice it skips select.
7. Apply the patch and then repeat steps 3-5, notice the select link can now be accessed through using the keyboard.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Brendan Gallagher 2016-01-23 19:08:22 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!
Comment 10 Julian Maurice 2016-01-25 11:52:10 UTC
Patch pushed to 3.22.x, will be in 3.22.2
Comment 11 Frédéric Demians 2016-01-25 16:28:17 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.