To reproduce: 1) Go to Tools -> Label creator -> New label batch 2) Add an item 3) Select the checkbox next to the item you just added and click 'Remove selected items' 4) A pop-up will say that you are yet to select an item - this is a bug. (I am aware of the missing word in the pop-up message, which has been fixed in Bug 15662). Setting severity to normal because it blocks the use of this button.
Created attachment 47293 [details] [review] Bug 15663: Fix 'remove selected items', add a 'delete batch' button In this patch I have fixed the 'Remove selected items' button. I have also added a 'Delete batch' button like there is in the Patron Card Creator. To test: 1) Go to Tools -> Label creator -> New label batch 2) Add 2 items 3) Select the checkbox next to an item you just added and click 'Remove selected items' 4) A pop-up will say that you are yet to select an item. (Please ignore the mistake in the pop-up message, this is being fixed in Bug 15662) 5) Apply patch and refresh. Confirm there is now a 'Delete batch' button in the toolbar 6) Select one item and click 'Remove selected items' 7) Confirm the item is deleted from the batch 8) Select the final item and click 'Remove selected items' 9) Pop-up message will tell you that deleting this item will delete the batch. Click 'Okay' 10) Click 'Delete batch' then 'Okay' 11) Confirm you are redirected to the Labels page and the batch has been deleted.
Good cath Aleisha
Created attachment 47309 [details] [review] [SIGNED-OFF]Bug 15663: Fix 'remove selected items', add a 'delete batch' button In this patch I have fixed the 'Remove selected items' button. I have also added a 'Delete batch' button like there is in the Patron Card Creator. To test: 1) Go to Tools -> Label creator -> New label batch 2) Add 2 items 3) Select the checkbox next to an item you just added and click 'Remove selected items' 4) A pop-up will say that you are yet to select an item. (Please ignore the mistake in the pop-up message, this is being fixed in Bug 15662) 5) Apply patch and refresh. Confirm there is now a 'Delete batch' button in the toolbar 6) Select one item and click 'Remove selected items' 7) Confirm the item is deleted from the batch 8) Select the final item and click 'Remove selected items' 9) Pop-up message will tell you that deleting this item will delete the batch. Click 'Okay' 10) Click 'Delete batch' then 'Okay' 11) Confirm you are redirected to the Labels page and the batch has been deleted. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised
Héctor, did you forget to set teh status tu signed-off? :-)
(In reply to Marc Véron from comment #4) > Héctor, did you forget to set teh status tu signed-off? :-) Thanks Marc. I've uncommented the line in git-bz, but maybe the program did not update.
Created attachment 47337 [details] [review] Bug 15663: Fix 'remove selected items', add a 'delete batch' button In this patch I have fixed the 'Remove selected items' button. I have also added a 'Delete batch' button like there is in the Patron Card Creator. To test: 1) Go to Tools -> Label creator -> New label batch 2) Add 2 items 3) Select the checkbox next to an item you just added and click 'Remove selected items' 4) A pop-up will say that you are yet to select an item. (Please ignore the mistake in the pop-up message, this is being fixed in Bug 15662) 5) Apply patch and refresh. Confirm there is now a 'Delete batch' button in the toolbar 6) Select one item and click 'Remove selected items' 7) Confirm the item is deleted from the batch 8) Select the final item and click 'Remove selected items' 9) Pop-up message will tell you that deleting this item will delete the batch. Click 'Okay' 10) Click 'Delete batch' then 'Okay' 11) Confirm you are redirected to the Labels page and the batch has been deleted. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This patch update the label editor behaviors with the patroncard ones, but there are still lot of issues: 1/ You can select all the items and click on "remove selected" without any warning 2/ You can delete the last item clicking on the "Delete" button ("actions" column) In these 2 cases, the batch_id parameter is passed but is wrong. If you add a new batch on the resulting screen, the batch_id of the deleted batch will be displayed, but a new one will be used.
(In reply to Jonathan Druart from comment #7) > This patch update the label editor behaviors with the patroncard ones, but > there are still lot of issues: > 1/ You can select all the items and click on "remove selected" without any > warning > 2/ You can delete the last item clicking on the "Delete" button ("actions" > column) > > In these 2 cases, the batch_id parameter is passed but is wrong. If you add > a new batch on the resulting screen, the batch_id of the deleted batch will > be displayed, but a new one will be used. I think these are separate bugs and they definitely do need fixing
(In reply to Aleisha Amohia from comment #8) > (In reply to Jonathan Druart from comment #7) > > This patch update the label editor behaviors with the patroncard ones, but > > there are still lot of issues: > > 1/ You can select all the items and click on "remove selected" without any > > warning > > 2/ You can delete the last item clicking on the "Delete" button ("actions" > > column) > > > > In these 2 cases, the batch_id parameter is passed but is wrong. If you add > > a new batch on the resulting screen, the batch_id of the deleted batch will > > be displayed, but a new one will be used. > > I think these are separate bugs and they definitely do need fixing See Bug 15663
(In reply to Marc Véron from comment #9) > > See Bug 15663 Do you mean Bug 14676?
(In reply to Aleisha Amohia from comment #10) > (In reply to Marc Véron from comment #9) > > > > See Bug 15663 > > Do you mean Bug 14676? Sorry for my mistake, it is Bug 15689 - Label editor: Fix issues with wrong batch_id parameter
Pushed to Master - Should be in the May 2016 Release - Thanks!
Patch pushed to stable, will be in 3.22.5