Bug 15672 - Show descriptions instead of codes on the hold ratios report
Summary: Show descriptions instead of codes on the hold ratios report
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-26 15:09 UTC by Katrin Fischer
Modified: 2016-12-05 21:27 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15672 - Show descriptions instead of codes on the hold ratios report (3.11 KB, patch)
2016-02-17 23:52 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 15672 - Show descriptions instead of codes on the hold ratios report (3.14 KB, patch)
2016-03-02 16:58 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 15672 [Revised] Show descriptions instead of codes on the hold ratios report (7.29 KB, patch)
2016-03-16 14:04 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15672 [Revised] Show descriptions instead of codes on the hold ratios report (7.42 KB, patch)
2016-03-16 15:42 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15672 [Revised] Show descriptions instead of codes on the hold ratios report (7.49 KB, patch)
2016-03-17 08:49 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15672: (follow-up) Show descriptions instead of codes on the hold ratios report (1.32 KB, patch)
2016-03-17 08:49 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2016-01-26 15:09:23 UTC
The hold ratios report available from the circulation module start page lists
- homebranch
- holdingbranch
- location
- itype
with the code, instead of the descriptions or names for each.

It would be nicer to show the descriptions.
Comment 1 Owen Leonard 2016-02-17 23:52:58 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2016-03-02 16:58:38 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-03 09:53:21 UTC
Owen, It cannot work.
These values can be multi-valuated (separated by <br/>) and the TT plugins do not manage that.
Comment 4 Katrin Fischer 2016-03-03 11:37:20 UTC
Hm sounds familiar - would something like the fix for http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=363cb9c02ed017a0a20951d5caa9f9e5376600d0 help?
Comment 5 Jonathan Druart 2016-03-03 11:49:53 UTC
Yes, I have searched for this patch but did not find it!
Comment 6 Katrin Fischer 2016-03-03 11:57:24 UTC
Ask a librarian :P
Comment 7 Owen Leonard 2016-03-16 14:04:37 UTC Comment hidden (obsolete)
Comment 8 Marc Véron 2016-03-16 15:42:38 UTC Comment hidden (obsolete)
Comment 9 Jonathan Druart 2016-03-17 08:49:56 UTC
Created attachment 49241 [details] [review]
Bug 15672 [Revised] Show descriptions instead of codes on the hold ratios report

This patch revises the hold ratios report so that it uses template
plugins to display descriptions instead of codes for item holding
branch, item home branch, item type, and shelving location.

To test you should have multiple items on the hold ratio report (set the
ratio to a small number to increase the number of results). It should
include one or more items which have a shelving location set.

View the hold ratios report and confirm that library names, shelving
location descriptions, and item type descriptions are shown instead of
codes.

This revised patch steals from Bug 15560 to enable the correct display
of multiple home libraries, holding libraries, shelving locations, item
types, and call numbers. To properly test you should have records in
your report which have multiple values for each of those fields.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 10 Jonathan Druart 2016-03-17 08:49:59 UTC
Created attachment 49242 [details] [review]
Bug 15672: (follow-up) Show descriptions instead of codes on the hold ratios report

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 11 Brendan Gallagher 2016-03-23 21:07:54 UTC
Pushed to Master - should be in the May 2016 release.  Thanks!