Single quotes audio selector break ability to edit an alert
Created attachment 47622 [details] [review] Bug 15735 - Audio Alerts editor broken by use of of single quotes in editor Single quotes audio selector break ability to edit an alert Test Plan: 1) Enable audio alerts 2) Add new a alert with a select containing single quotes such as: input[name*='test'] 3) Note you cannot edit the alert 4) Apply this patch 5) Reload the page 6) You should now be able to edit the alert
Created attachment 47623 [details] [review] Bug 15735 - Audio Alerts editor broken by use of of single quotes in editor Single quotes audio selector break ability to edit an alert Test Plan: 1) Enable audio alerts 2) Add new a alert with a select containing single quotes such as: input[name*='test'] 3) Note you cannot edit the alert 4) Apply this patch 5) Reload the page 6) You should now be able to edit the alert
fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc).
(In reply to Mirko Tietgen from comment #3) > fatal: sha1 information is lacking or useless > (koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc). Forgot to mark this bug as dependent on 15734!
Created attachment 47645 [details] [review] [SIGNED-OFF]Bug 15735: Audio Alerts editor broken by use of of single quotes in editor Single quotes audio selector break ability to edit an alert Test Plan: 1) Enable audio alerts 2) Add new a alert with a select containing single quotes such as: input[name*='test'] 3) Note you cannot edit the alert 4) Apply this patch 5) Reload the page 6) You should now be able to edit the alert Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Bug 15734 applied on top. Works as advertised
Created attachment 47736 [details] [review] Bug 15735: Audio Alerts editor broken by use of of single quotes in editor Single quotes audio selector break ability to edit an alert Test Plan: 1) Enable audio alerts 2) Add new a alert with a select containing single quotes such as: input[name*='test'] 3) Note you cannot edit the alert 4) Apply this patch 5) Reload the page 6) You should now be able to edit the alert Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Bug 15734 applied on top. Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Blocked by 15734 being BLOCKED
Created attachment 48763 [details] [review] Bug 15735: Audio Alerts editor broken by use of of single quotes in editor Single quotes audio selector break ability to edit an alert Test Plan: 1) Enable audio alerts 2) Add new a alert with a select containing single quotes such as: input[name*='test'] 3) Note you cannot edit the alert 4) Apply this patch 5) Reload the page 6) You should now be able to edit the alert Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Bug 15734 applied on top. Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
pushed to Master - Should be in the May 2016 release. Thanks
Patch pushed to 3.22.x, will be in 3.22.5