Building on from Bug 15785
Created attachment 48081 [details] [review] Bug 15821: Use Font Awesome icons in confirmation dialogs - Circulation To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Circulation -> Check out -> An item that is checked out by someone else -> An item that is on hold to someone else -> To a patron that has more than noisuescharge in fines (Allow AllowFineOverride syspref) -> To a patron that has reached the max amount of checkouts (Allow AllowTooManyOverride syspref) -> To a patron that has more than noissuescharge in fines (Allow AllowFineOverride syspref and set noissuescharge syspref) -> Renew -> An item that is on hold to someone else -> To a patron that is at max renewals (Allow AllowRenewalLimitOverride syspref) -> An item that is not checked out by anyone -> Check in -> An item that is in transit to another branch And look for other confirmation dialogs and check if I've missed any Sponsored-by: Catalyst IT
Everything looks good except these issues: - The "Cancel checkout and place hold" button isn't working for me. Nothing happens when I click it. - On the batch checkout screen, I don't think it is consistent to add an icon to that button. At this time we don't have a standard of adding icons to every submit button. - Missing closing bracket on line 52 of renew.tt: <button type="submit" class="approve"><i class="fa fa-check"</i> Override limit and renew</button>
Created attachment 48321 [details] [review] Bug 15821: Use Font Awesome icons in confirmation dialogs - Circulation To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Circulation -> Check out -> An item that is checked out by someone else -> An item that is on hold to someone else -> To a patron that has more than noisuescharge in fines (Allow AllowFineOverride syspref) -> To a patron that has reached the max amount of checkouts (Allow AllowTooManyOverride syspref) -> To a patron that has more than noissuescharge in fines (Allow AllowFineOverride syspref and set noissuescharge syspref) -> Renew -> An item that is on hold to someone else -> To a patron that is at max renewals (Allow AllowRenewalLimitOverride syspref) -> An item that is not checked out by anyone -> Check in -> An item that is in transit to another branch And look for other confirmation dialogs and check if I've missed any Sponsored-by: Catalyst IT EDIT: Made changes from Comment 2
Created attachment 48366 [details] [review] [SIGNED-OFF] Bug 15821: Use Font Awesome icons in confirmation dialogs - Circulation To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Circulation -> Check out -> An item that is checked out by someone else -> An item that is on hold to someone else -> To a patron that has more than noisuescharge in fines (Allow AllowFineOverride syspref) -> To a patron that has reached the max amount of checkouts (Allow AllowTooManyOverride syspref) -> To a patron that has more than noissuescharge in fines (Allow AllowFineOverride syspref and set noissuescharge syspref) -> Renew -> An item that is on hold to someone else -> To a patron that is at max renewals (Allow AllowRenewalLimitOverride syspref) -> An item that is not checked out by anyone -> Check in -> An item that is in transit to another branch And look for other confirmation dialogs and check if I've missed any Sponsored-by: Catalyst IT EDIT: Made changes from Comment 2 Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 48438 [details] [review] Bug 15821: Use Font Awesome icons in confirmation dialogs - Circulation To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Circulation -> Check out -> An item that is checked out by someone else -> An item that is on hold to someone else -> To a patron that has more than noisuescharge in fines (Allow AllowFineOverride syspref) -> To a patron that has reached the max amount of checkouts (Allow AllowTooManyOverride syspref) -> To a patron that has more than noissuescharge in fines (Allow AllowFineOverride syspref and set noissuescharge syspref) -> Renew -> An item that is on hold to someone else -> To a patron that is at max renewals (Allow AllowRenewalLimitOverride syspref) -> An item that is not checked out by anyone -> Check in -> An item that is in transit to another branch And look for other confirmation dialogs and check if I've missed any Sponsored-by: Catalyst IT EDIT: Made changes from Comment 2 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
note that this patch also changes the wording "Click here to place a hold for " to "Cancel checkout and place a hold for".
*** Bug 15681 has been marked as a duplicate of this bug. ***
Pushed to Master - Should be in the May 2016 Release. Thanks
*** Bug 14171 has been marked as a duplicate of this bug. ***