Bug 15826 - Use Font Awesome icons in confirmation dialogs - Tools
Summary: Use Font Awesome icons in confirmation dialogs - Tools
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on: 15785
Blocks:
  Show dependency treegraph
 
Reported: 2016-02-16 02:43 UTC by Aleisha Amohia
Modified: 2016-12-05 21:27 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15826 - Use Font Awesome icons in confirmation dialogs - Tools (1.64 KB, patch)
2016-02-16 04:40 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15826 - Use Font Awesome icons in confirmation dialogs - Tools (1.77 KB, patch)
2016-02-16 10:23 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15826 - Use Font Awesome icons in confirmation dialogs - Tools (1.84 KB, patch)
2016-02-16 10:36 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-02-16 02:43:57 UTC
Building on from Bug 15785
Comment 1 Aleisha Amohia 2016-02-16 04:40:53 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-02-16 10:23:44 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-02-16 10:36:25 UTC
Created attachment 48110 [details] [review]
Bug 15826 - Use Font Awesome icons in confirmation dialogs - Tools

I only found one confirmation dialog, all the others use javascript.

To test:
Go to Tools -> Notices and Slips
Click Delete on a notice
Confirm Yes and No options still work as expected
Check Tools module in case I missed any confirm dialogs

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-02-24 03:38:20 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!