Bug 15848 - Correct JSHint errors in acq.js
Summary: Correct JSHint errors in acq.js
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-17 17:43 UTC by Owen Leonard
Modified: 2016-02-17 17:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-02-17 17:43:23 UTC 
Following coding guideline JS8: "Follow guidelines set by JSHint," some errors should be corrected in acq.js

koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 5, col 17, Do not use Number as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 11, col 21, Do not use Number as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 25, col 24, Use '===' to compare with '0'.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 40, col 13, Do not use Number as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 44, col 18, Use '===' to compare with '0'.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 44, col 32, Use '===' to compare with ''.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 73, col 17, Use '===' to compare with 'null'.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 74, col 17, Use '===' to compare with 'null'.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 75, col 23, The array literal notation [] is preferable.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 110, col 14, Do not use Number as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 114, col 24, Use '===' to compare with '0'.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 129, col 24, Do not use Number as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 129, col 28, Missing '()' invoking a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 134, col 15, Do not use Number as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 134, col 19, Missing '()' invoking a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 136, col 31, The array literal notation [] is preferable.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 140, col 27, Use '===' to compare with '0'.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 147, col 19, Do not use Number as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 148, col 16, Do not use Number as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 150, col 14, 'i' is already defined.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 179, col 20, Do not use Number as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 180, col 20, Do not use Number as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 181, col 24, Do not use Number as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 182, col 20, Do not use String as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 183, col 25, Do not use Number as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 186, col 17, Do not use Number as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 189, col 17, Do not use Number as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 191, col 18, Do not use Number as a constructor.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 220, col 13, Use '===' to compare with 'null'.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 220, col 28, Use '===' to compare with ''.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 258, col 24, eval can be harmful.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 267, col 6, Missing semicolon.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 287, col 50, Missing semicolon.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 287, col 52, Unnecessary semicolon.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 288, col 66, Missing semicolon.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 288, col 67, Unnecessary semicolon.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 302, col 18, eval can be harmful.
koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 336, col 18, eval can be harmful.