Bug 15978 - Use Font Awesome icons for guided reports error dialog
Summary: Use Font Awesome icons for guided reports error dialog
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/reports/guided_reports....
Keywords:
Depends on: 15785
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-04 12:59 UTC by Owen Leonard
Modified: 2017-06-14 22:11 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15978 - Use Font Awesome icons for guided reports error dialog (6.77 KB, patch)
2016-03-04 13:49 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15978: Use Font Awesome icons for guided reports error dialog (6.82 KB, patch)
2016-03-04 14:52 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15978: Use Font Awesome icons for guided reports error dialog (6.87 KB, patch)
2016-03-10 11:28 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-04 12:59:24 UTC
If you create or update an SQL report using an invalid authorized value a dialog will ask you to confirm before saving the report. This dialog should use Font Awesome icons.
Comment 1 Owen Leonard 2016-03-04 13:49:19 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-03-04 14:52:16 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-10 11:28:39 UTC
Created attachment 48942 [details] [review]
Bug 15978: Use Font Awesome icons for guided reports error dialog

If you try to save an SQL report with an invalid authorized value
placeholder you will be presented with a confirmation dialog. This patch
updates it to use Font Awesome icons.

Also fixed: Validation error found in testing: Duplicated <form> tag and
series of redundant inputs. Each input cut had an exact duplicate in the
same form.

To test, apply the patch and go to Reports -> Create from SQL.

- Create a new SQL report and fill in as many fields as possible to
  verify correct operation.
- Try to save your report with an invalid authorized value
  placeholder, for example: SELECT * FROM items WHERE items.itype =
  <<foo|bar>>
- Confirm that the confirmation dialog is styled correctly.
- Test the operation of the "Edit SQL" button. You should be sent back a
  page.
- Test the operation of the "Save anyway" button and confirm that your
  report was saved.
- Repeat these steps when editing an existing report.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as described

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-03-12 23:32:14 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!