Bug 16107 - print slip buttons do different things
Summary: print slip buttons do different things
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-18 15:22 UTC by Nicole C. Engard
Modified: 2019-10-14 19:56 UTC (History)
1 user (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Crowdfunding committed: 0
Crowdfunding contact:
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
prompt (20.28 KB, image/jpeg)
2016-03-18 15:22 UTC, Nicole C. Engard
Details
print and confirm button (17.98 KB, image/jpeg)
2016-03-18 15:22 UTC, Nicole C. Engard
Details
print slip link (17.72 KB, image/jpeg)
2016-03-18 15:22 UTC, Nicole C. Engard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2016-03-18 15:22:25 UTC
Created attachment 49319 [details]
prompt

I think this is a template issue but feel free to recateogorize.

We had this issue pop up today for item 0114961548103 while being checked in at Hudson. The item's home branch is Hugh Embry and it needs to go to the New River branch. When being checked in, there are two options to print a transfer slip on the check in prompt: the "Print slip" link near the top and the "Print slip and confirm" button near the bottom. If you choose the "Print slip" link at the top, the slip INCORRECTLY reads "Transfer to Hugh Embry." If you choose the "Print slip and confirm" button at the bottom, the slip correctly reads "Transfer to New River."

Based on the labels, I would expect the link and the button to do the same thing.
Comment 1 Nicole C. Engard 2016-03-18 15:22:40 UTC
Created attachment 49320 [details]
print and confirm button
Comment 2 Nicole C. Engard 2016-03-18 15:22:54 UTC
Created attachment 49321 [details]
print slip link
Comment 3 Owen Leonard 2016-03-21 14:10:35 UTC
This happens because two things are going on at once, and Koha doesn't know how to prioritize which operation should be offered to the user.

As far as I know, in order to reproduce this problem you have to do this:

1. Check in an item from Branch A at Branch B. This initiates a transfer between branches.

2. Place a hold on the item for a patron at any branch. Check in the item again.

Because the transfer was initiated in step 1 Koha thinks it should remind you that a transfer is in progress and wants to to print a slip for that transfer (the "Print slip" link at the top of the screenshot).

Because the item is also on hold for someone Koha prompts you to print a slip for the hold (the "Print slip and confirm" button in the screenshot).

I'm inclined to think that the hold operation should take priority and the existing transfer should not get a prompt. However, a hold prompt would normally also have an "Ignore" option, which isn't present in this case. If you chose to ignore the hold, it seems logical that the transfer would then become an issue which should be prompted about.

That's probably a matter of opinion, and I don't think there is an easy solution either way.