Bug 16126 - Display base-level amounts on the acquisition module home page
Summary: Display base-level amounts on the acquisition module home page
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Rémi Mayrand-Provencher
QA Contact: Testopia
URL:
Keywords:
: 15659 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-03-22 16:18 UTC by Francois Charbonnier
Modified: 2020-01-08 23:07 UTC (History)
17 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16126 - Display base-level amounts on the acquisition module home page (4.86 KB, patch)
2016-04-19 19:11 UTC, Rémi Mayrand-Provencher
Details | Diff | Splinter Review
Bug 16126 - Display base-level amounts on the acquisition module home page (5.03 KB, patch)
2016-05-31 15:18 UTC, Marc Véron
Details | Diff | Splinter Review
Screenshot of current table on acq start page (61.26 KB, image/png)
2016-09-25 20:21 UTC, Katrin Fischer
Details
Screenshot of proposed change to the table (65.07 KB, image/png)
2016-09-25 20:22 UTC, Katrin Fischer
Details
Bug 16126 - Display base-level amounts on the acquisition module home page (5.59 KB, patch)
2017-06-26 17:34 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 16126 - Display base-level amounts on the acquisition module home page (5.36 KB, patch)
2019-01-16 21:06 UTC, José-Mario Monteiro-Santos
Details | Diff | Splinter Review
Bug 16126 - Display base-level amounts on the acquisition module home page (5.48 KB, patch)
2019-10-04 13:33 UTC, sandboxes@biblibre.com
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Francois Charbonnier 2016-03-22 16:18:03 UTC
This patch will display on the acquisition module home page the information already displayed on the "manage fund" page (aqbudgets.pl).

Currently, Koha display the base-level amounts only.

This patch will :

1. rename the column "ordered", "spent" and "available" to "base-level [ordered|spent|available]"

2. add the column "ordered", "spent" and available with the same calculation from the "manage fund" page.

TEST PLAN :

1. Go to the Administration module
2. Add a new budget (ie : Budget 2016)
3. Add a fund to this budget (ie : Book)
4. Add a child fund (ie : Adult fiction)

You will have this hierarchy :

Budget 2016
 |____ Book
         |_____ Adult fiction


5. Go to the Acquisition module
6. Place an order and use the "Adult fiction" budget
7. Go back the Acquisition home page and compare the table with the table from the aqbudgets.pl page (Administration > Budget > Fund)
8. You will see :

BEFORE PATCH :
the base level amounts only

AFTER PATCH :
the base level and the total amounts
Comment 1 Rémi Mayrand-Provencher 2016-04-19 19:11:03 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-05-31 15:18:41 UTC
Created attachment 51931 [details] [review]
Bug 16126 - Display base-level amounts on the acquisition module home page

This patch will display on the acquisition module home page the information already displayed on the "manage fund" page (aqbudgets.pl).

Currently, Koha display the base-level amounts only.

This patch will :

1. rename the column "ordered", "spent" and "available" to "base-level [ordered|spent|available]"

2. add the column "ordered", "spent" and available with the same calculation from the "manage fund" page.

TEST PLAN :

1. Go to the Administration module
2. Add a new budget (ie : Budget 2016)
3. Add a fund to this budget (ie : Book)
4. Add a child fund (ie : Adult fiction)

You will have this hierarchy :

Budget 2016
 |____ Book
         |_____ Adult fiction

5. Go to the Acquisition module
6. Place an order and use the "Adult fiction" budget
7. Go back the Acquisition home page and compare the table with the table from the aqbudgets.pl page (Administration > Budget > Fund)
8. You will see :

BEFORE PATCH :
the base level amounts only

AFTER PATCH :
the base level and the total amounts

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Comment 3 Jonathan Druart 2016-07-01 15:29:16 UTC
I think that the goal of this table (on the acq home page) was to display a simplified version of the table on the "all funds" view.
Comment 4 Katrin Fischer 2016-09-25 20:20:02 UTC
I've added this bug to the next dev meeting's agenda.
Comment 5 Katrin Fischer 2016-09-25 20:21:35 UTC
Created attachment 55810 [details]
Screenshot of current table on acq start page
Comment 6 Katrin Fischer 2016-09-25 20:22:12 UTC
Created attachment 55811 [details]
Screenshot of proposed change to the table
Comment 7 Tomás Cohen Arazi 2017-06-26 17:34:27 UTC
Created attachment 64659 [details] [review]
Bug 16126 - Display base-level amounts on the acquisition module home page

This patch will display on the acquisition module home page the information already displayed on the "manage fund" page (aqbudgets.pl).

Currently, Koha display the base-level amounts only.

This patch will :

1. rename the column "ordered", "spent" and "available" to "base-level [ordered|spent|available]"

2. add the column "ordered", "spent" and available with the same calculation from the "manage fund" page.

TEST PLAN :

1. Go to the Administration module
2. Add a new budget (ie : Budget 2016)
3. Add a fund to this budget (ie : Book)
4. Add a child fund (ie : Adult fiction)

You will have this hierarchy :

Budget 2016
 |____ Book
         |_____ Adult fiction

5. Go to the Acquisition module
6. Place an order and use the "Adult fiction" budget
7. Go back the Acquisition home page and compare the table with the table from the aqbudgets.pl page (Administration > Budget > Fund)
8. You will see :

BEFORE PATCH :
the base level amounts only

AFTER PATCH :
the base level and the total amounts

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
I tested the functionality and it works as expected. It also passes the QA script.
It basically adds 'base-level' information to the acquisitions page. The only difference
with what is displayed on the funds page is that it doesn't add the base-level available
amounts. So the table is more compact and easy to follow.

I think this is a useful enhancement even if it makes this table closer to the funds one.
I checked it totalizes correctly on each scenario and respects the acq workflow exactly as
the funds table.
Comment 8 Jonathan Druart 2017-07-05 23:23:30 UTC
(In reply to Tomás Cohen Arazi from comment #7)
> So the table is more compact and easy to follow.

Well not really, it is less compact than before.

I'd like more opinions on this one, Nicolas, Séverine or Sonia maybe (See comments 5 & 6).
Comment 9 Tomás Cohen Arazi 2017-07-06 13:08:53 UTC
(In reply to Jonathan Druart from comment #8)
> (In reply to Tomás Cohen Arazi from comment #7)
> > So the table is more compact and easy to follow.
> 
> Well not really, it is less compact than before.

I meant it was more compact than the funds one. Of course it is adding columns to the original one! hehe

> I'd like more opinions on this one, Nicolas, Séverine or Sonia maybe (See
> comments 5 & 6).

Yeah, I think it is important to listen to interested parties. My feeling is that the 'compact' one (a.k.a. 'the original') is not useful at all. Even if it was just duplicating the funds one, I think it is worth doing.
Comment 10 Kyle M Hall 2017-07-06 14:27:03 UTC
(In reply to Tomás Cohen Arazi from comment #9)
> (In reply to Jonathan Druart from comment #8)
> > (In reply to Tomás Cohen Arazi from comment #7)
> > > So the table is more compact and easy to follow.
> > 
> > Well not really, it is less compact than before.
> 
> I meant it was more compact than the funds one. Of course it is adding
> columns to the original one! hehe
> 
> > I'd like more opinions on this one, Nicolas, Séverine or Sonia maybe (See
> > comments 5 & 6).
> 
> Yeah, I think it is important to listen to interested parties. My feeling is
> that the 'compact' one (a.k.a. 'the original') is not useful at all. Even if
> it was just duplicating the funds one, I think it is worth doing.

I agree with Tomas. In addition table columns can always be hidden with css as link as they are IDed/classed properly. I don't think you'll every find a library that strongly expressed how this table has too much data ; )
Comment 11 J Schmidt 2017-07-06 16:34:21 UTC
(In reply to Kyle M Hall from comment #10)
> (In reply to Tomás Cohen Arazi from comment #9)
> > (In reply to Jonathan Druart from comment #8)
> > > (In reply to Tomás Cohen Arazi from comment #7)
> > > > So the table is more compact and easy to follow.
> > > 
> > > Well not really, it is less compact than before.
> > 
> > I meant it was more compact than the funds one. Of course it is adding
> > columns to the original one! hehe
> > 
> > > I'd like more opinions on this one, Nicolas, Séverine or Sonia maybe (See
> > > comments 5 & 6).
> > 
> > Yeah, I think it is important to listen to interested parties. My feeling is
> > that the 'compact' one (a.k.a. 'the original') is not useful at all. Even if
> > it was just duplicating the funds one, I think it is worth doing.
> 
> I agree with Tomas. In addition table columns can always be hidden with css
> as link as they are IDed/classed properly. I don't think you'll every find a
> library that strongly expressed how this table has too much data ; )

Our consortium had requested this development.  The libraries are accustomed to not being able to see each other's budgets and actually dollar amounts..I believe that falls outside the scope of this bug but I'll reiterate that it would be great and would consolidate the amount of information on the /koha/acqui/acqui-home.pl screen if the budget displaying was only for whichever branch library is logged in... (Tied to the staff login)... The more direct response/comment I'll make is that our staff would like the amounts for all funds summed on that acqui-home.pl page for the active budget... This is especially useful right now as we have one library's budget in a table directly followed by another branch's active budget and it would be nice to break up the table with a SUM for each budget.... This remains a desire of our library system. Thanks. jenschmidt~
Comment 12 Katrin Fischer 2017-07-06 17:30:12 UTC
Hm, it's already possible to control visibility with the permissions on fund level. You can especially limit to the home library of the patron.

I think restricting to only the library you are logged in at is too general and would not work for every library system. There are setups where a main library orders for all others. This should be configurable, but we already have a complicated permission system on the funds. I feel like we should not make it more complicated.

Hiding columns/cells is often not really possible when datatables are used - this table is getting more and more complicated. So even if there are ids, it's not always easy to make it work.

I feel we should have a clear concept about what is the difference (or not) between the one on acq home page and the one on the funds page.
Comment 13 Katrin Fischer 2017-07-06 17:37:49 UTC
> Our consortium had requested this development.  The libraries are accustomed
> to not being able to see each other's budgets and actually dollar amounts..I
> believe that falls outside the scope of this bug but I'll reiterate that it
> would be great and would consolidate the amount of information on the
> /koha/acqui/acqui-home.pl screen if the budget displaying was only for
> whichever branch library is logged in... (Tied to the staff login)... The
> more direct response/comment I'll make is that our staff would like the
> amounts for all funds summed on that acqui-home.pl page for the active
> budget... This is especially useful right now as we have one library's
> budget in a table directly followed by another branch's active budget and it
> would be nice to break up the table with a SUM for each budget.... This
> remains a desire of our library system. Thanks. jenschmidt~

To not see another libraries funds on the start page:
- Make sure user does have neither superlibrarian or budget_manage_all permission
- Make sure each fund has a library set and is restricted to: owner, users and library
The user will only see their home branches funds.
Comment 14 J Schmidt 2017-07-06 19:37:32 UTC
Basically our group is still interested. We want a subtotal per branch's budget on the acqui-home.pl page. Right now the total at the bottom isn't calculated correctly and is including multiple branches and their budgets.....Staff are able to view funds and dollar amounts tied to funds for any library's budget. There are permission restrictions at the point of ordering and editing. However, the viewing of budget information on a few Koha Acq pages still remains.  Thanks. jls.
Comment 15 Katrin Fischer 2017-07-06 20:15:40 UTC
(In reply to J Schmidt from comment #14)
> Basically our group is still interested. We want a subtotal per branch's
> budget on the acqui-home.pl page. Right now the total at the bottom isn't
> calculated correctly and is including multiple branches and their
> budgets.....Staff are able to view funds and dollar amounts tied to funds
> for any library's budget. There are permission restrictions at the point of
> ordering and editing. However, the viewing of budget information on a few
> Koha Acq pages still remains.  Thanks. jls.

Please don't misunderstand my comments, I am trying to help, because I think what you describe might already be possible without these patches. I have just run tests on master with 1 budget and 2 funds for different libraries. When I set the permissions so I only see the fund of my library, then the Total is correctly calculated to only include the funds visible to me. So I guess I am missing something and I would like to understand.

But as this is kind of a separate discussion from this bug, we should probably move it onto a different bug report. Would you be willing to write it up?
Comment 16 J Schmidt 2017-07-10 15:56:51 UTC
Hello Katrin, I hope this is possible. I don't mind being corrected. Just to clarify, one branch library wants to ONLY view their own budget from the acqui/acqui-home.pl screen. ... not any other libraries' budgets or funds (with dollar amounts)... I am not seeing  any permissions where one can manage and view only their library's budget... I'll double check to see if the one branch I'm looking at today has a proper total at the bottom given how I'm logged in (as that same branch). Maybe the total at the bottom is correct for the branch EVEN THOUGH I can view the other budgets in the table as a whole. That's possible. thanks. jen.
Comment 17 Katrin Fischer 2017-07-10 16:18:34 UTC
Hi Jen, take a look at comment#13 especially:
- make sure the user you are testing with has neither budget_manage_all nor superlibrarian permission. They will have budget_manage_all if they have full acq permissions, so you might have to uncheck it.
- go to the funds configuration page for the rest.
Good luck!
Comment 18 Koha Team University Lyon 3 2017-07-12 09:57:02 UTC
Hello,
we are not using child fund in my library so we aren't really concerned. But, if the table is less compact than before it's still acceptable for me.
More opinion from librarians using child fund would be better than my reply on this one..

But, concerning the discussion between Katrin and Jen, in my library, we need to see funds from all branches on acq-home page. I'm agree with Katrin, it's possible to change the display of acq-home page according to user permissions and fund setting.

Sonia
Comment 19 J Schmidt 2017-08-25 17:02:16 UTC
Hello,
I finally had the chance to come back to this today. Thank you Katrin as I believe I have made changes to staff permissions to successfully limit the viewing of non-home library budgets. Appreciated.
Comment 20 Charles Farmer 2018-12-28 22:28:01 UTC
Doesn't apply, will submit rebase
Comment 21 José-Mario Monteiro-Santos 2019-01-16 21:06:35 UTC
Created attachment 84094 [details] [review]
Bug 16126 - Display base-level amounts on the acquisition module home page

This patch will display on the acquisition module home page the information already displayed on the "manage fund" page (aqbudgets.pl).

Currently, Koha display the base-level amounts only.

This patch will :

1. rename the column "ordered", "spent" and "available" to "base-level [ordered|spent|available]"

2. add the column "ordered", "spent" and available with the same calculation from the "manage fund" page.

TEST PLAN :

1. Go to the Administration module
2. Add a new budget (ie : Budget 2016)
3. Add a fund to this budget (ie : Book)
4. Add a child fund (ie : Adult fiction)

You will have this hierarchy :

Budget 2016
 |____ Book
         |_____ Adult fiction

5. Go to the Acquisition module
6. Place an order and use the "Adult fiction" budget
7. Go back the Acquisition home page and compare the table with the table from the aqbudgets.pl page (Administration > Budget > Fund)
8. You will see :

BEFORE PATCH :
the base level amounts only

AFTER PATCH :
the base level and the total amounts

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
I tested the functionality and it works as expected. It also passes the QA script.
It basically adds 'base-level' information to the acquisitions page. The only difference
with what is displayed on the funds page is that it doesn't add the base-level available
amounts. So the table is more compact and easy to follow.

I think this is a useful enhancement even if it makes this table closer to the funds one.
I checked it totalizes correctly on each scenario and respects the acq workflow exactly as
the funds table.
Comment 22 sandboxes@biblibre.com 2019-10-04 13:33:11 UTC
Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr>
Comment 23 sandboxes@biblibre.com 2019-10-04 13:33:41 UTC
Created attachment 93747 [details] [review]
Bug 16126 - Display base-level amounts on the acquisition module home page

This patch will display on the acquisition module home page the information already displayed on the "manage fund" page (aqbudgets.pl).

Currently, Koha display the base-level amounts only.

This patch will :

1. rename the column "ordered", "spent" and "available" to "base-level [ordered|spent|available]"

2. add the column "ordered", "spent" and available with the same calculation from the "manage fund" page.

TEST PLAN :

1. Go to the Administration module
2. Add a new budget (ie : Budget 2016)
3. Add a fund to this budget (ie : Book)
4. Add a child fund (ie : Adult fiction)

You will have this hierarchy :

Budget 2016
 |____ Book
         |_____ Adult fiction

5. Go to the Acquisition module
6. Place an order and use the "Adult fiction" budget
7. Go back the Acquisition home page and compare the table with the table from the aqbudgets.pl page (Administration > Budget > Fund)
8. You will see :

BEFORE PATCH :
the base level amounts only

AFTER PATCH :
the base level and the total amounts

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
I tested the functionality and it works as expected. It also passes the QA script.
It basically adds 'base-level' information to the acquisitions page. The only difference
with what is displayed on the funds page is that it doesn't add the base-level available
amounts. So the table is more compact and easy to follow.

I think this is a useful enhancement even if it makes this table closer to the funds one.
I checked it totalizes correctly on each scenario and respects the acq workflow exactly as
the funds table.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Comment 24 Katrin Fischer 2020-01-08 23:07:18 UTC
*** Bug 15659 has been marked as a duplicate of this bug. ***