Bug 16178 - Tests for xt/single_quotes.t are failing
Summary: Tests for xt/single_quotes.t are failing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 15206
Blocks:
  Show dependency tree / graph
 
Reported: 2016-03-31 08:05 UTC by Jonathan Druart
Modified: 2016-12-05 21:23 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 16178: Fix tests for xt/single_quotes.t (1.60 KB, patch)
2016-03-31 08:07 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 16178: Fix tests for xt/single_quotes.t (1.65 KB, patch)
2016-03-31 19:16 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Bug 16178: Fix tests for xt/single_quotes.t (1.75 KB, patch)
2016-04-01 08:35 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-03-31 08:05:21 UTC 

    


    


      

          
            
          


        
          Comment 1
        

        
          Jonathan Druart

        

        
        

        
          2016-03-31 08:07:44 UTC
        

          
            Comment hidden (obsolete)
          
      






    


    


      

          
            
          


        
          Comment 2
        

        
          Nick Clemens (kidclamp)

        

        
        

        
          2016-03-31 19:16:07 UTC
        

          
            Comment hidden (obsolete)
          
      






    


    


      



        
          Comment 3
        

        
          Marcel de Rooy

        

        
        

        
          2016-04-01 08:35:51 UTC
        

      






Created attachment 49776 [details] [review]
Bug 16178: Fix tests for xt/single_quotes.t

Caused by
  commit 9c5c1bc9f104b125e06b3805ce510024e6ad34ac
    Bug 15206: Make strings translatable

Test plan:
  prove xt/single_quotes.t
should return green

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

    


    


      



        
          Comment 4
        

        
          Marcel de Rooy

        

        
        

        
          2016-04-01 08:37:46 UTC
        

      






Spotted another one (outside the templates) too:
cataloguing/value_builder/unimarc_leader.pl:        alert(_('leader has an incor

But fixing that one is useless.

    


    


      



        
          Comment 5
        

        
          Brendan Gallagher

        

        
        

        
          2016-04-01 19:06:30 UTC
        

      






Pushed to Master - Should be in the May 2016 release.  Thanks!

    


    


      



        
          Comment 6
        

        
          Julian Maurice

        

        
        

        
          2016-04-07 08:20:14 UTC
        

      






Not needed in stable versions, status changed to RESOLVED