Bug 16343 - 7XX XSLT subfields displaying out of order
Summary: 7XX XSLT subfields displaying out of order
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Héctor Eduardo Castro Avalos
QA Contact: Testopia
URL:
Keywords:
: 16475 (view as bug list)
Depends on: 15100
Blocks:
  Show dependency treegraph
 
Reported: 2016-04-25 20:23 UTC by Danielle Elder
Modified: 2017-12-07 22:16 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Screenshot of out of order 7XX fields in display (100.69 KB, image/jpeg)
2016-04-25 20:23 UTC, Danielle Elder
Details
Marc record with multiple 7XX heading to test (4.55 KB, text/plain)
2016-04-28 19:20 UTC, Héctor Eduardo Castro Avalos
Details
Bug 16343: 7XX XSLT subfields displaying out of order (7.44 KB, patch)
2016-04-28 19:31 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 16343: 7XX XSLT subfields displaying out of order (7.50 KB, patch)
2016-04-29 22:06 UTC, Danielle Elder
Details | Diff | Splinter Review
Two MARC21 records to test with multiples 7XX fields (7.73 KB, text/plain)
2016-05-02 21:18 UTC, Héctor Eduardo Castro Avalos
Details
Bug 16343: 7XX XSLT subfields displaying out of order (40.54 KB, patch)
2016-05-02 21:29 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 16343: 7XX XSLT subfields displaying out of order (40.57 KB, patch)
2016-05-04 14:45 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 16343: 7XX XSLT subfields displaying out of order (40.57 KB, patch)
2016-05-04 20:21 UTC, Danielle Elder
Details | Diff | Splinter Review
Bug 16343: 7XX XSLT subfields displaying out of order (40.63 KB, patch)
2016-05-04 20:38 UTC, Danielle Elder
Details | Diff | Splinter Review
[PASSED QA] Bug 16343: 7XX XSLT subfields displaying out of order (40.69 KB, patch)
2016-05-19 05:15 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Danielle Elder 2016-04-25 20:23:06 UTC
Created attachment 50667 [details]
Screenshot of out of order 7XX fields in display

Hello, the subfields are out of order.

Marc is: 

  700 1# - ADDED ENTRY--PERSONAL NAME

  a Personal name Caspary, Vera,

  d Dates associated with a name 1899-1987.

  t Title of a work Laura.

Displays as such:

   700, a,t,d

from catalog Normal View:

   Caspary, Vera, Laura 1899-1987. 

Can the subfields be ordered alphabetically?

From Patricia

Comment 56 asked for an example. We have a title Women crime writers where several of the 700 fields have inverted the author's date subfield with the title field. See http://catalog.roundrocktexas.gov/cgi-bin/koha/opac-detail.pl?biblionumber=189060. Specifically: ex.1) Caspary, Vera, Laura 1899-1987. should be: Caspary, Vera, 1899-1987. Laura. -- ex.2) Hughes, Dorothy B. In a lonely place 1904-1993. should be: Hughes, Dorothy B.,1904-1993. In a lonely place. -- ex. 3) Holding, Elisabeth Sanxay, The blank wall 1889-1955. should be: Holding, Elisabeth Sanxay, 1889-1955. The blank wall. There are 3 more examples in this record alone.  Another example is Dancing home. See: http://catalog.roundrocktexas.gov/cgi-bin/koha/opac-search.pl?idx=ti&q=dancing+home. Darío, Rubén, A Margarita 1867-1916. should be Darío, Rubén, 1867-1916. A Margarita.
Comment 1 Héctor Eduardo Castro Avalos 2016-04-28 19:20:23 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-04-28 19:31:29 UTC Comment hidden (obsolete)
Comment 3 Héctor Eduardo Castro Avalos 2016-04-28 19:48:55 UTC
>Playing with the three classes:
By: International Congress of Gerontology. Satellite Conference (1978 : Sydney, N.S.W.).
Contributor(s): Weinman, Sarah | Caspary, Vera | Eustis, Helen | Hughes, Dorothy B. (Dorothy Belle)

>"ith: .titleportion and .relatorcode
By: International Congress of Gerontology. Satellite Conference (1978 : Sydney, N.S.W.).
Contributor(s): Weinman, Sarah | Caspary, Vera, 1899-1987 | Eustis, Helen | Hughes, Dorothy B. (Dorothy Belle), 1904-1993

>Only title portion
 International Congress of Gerontology. Satellite Conference (1978 : Sydney, N.S.W.) [depicted.].
Contributor(s): Weinman, Sarah [editor of compilation.] | Caspary, Vera, 1899-1987 | Eustis, Helen | Hughes, Dorothy B. (Dorothy Belle), 1904-1993

>Without classes
By: International Congress of Gerontology. Satellite Conference (1978 : Sydney, N.S.W.) [depicted.].
Contributor(s): Weinman, Sarah. [editor of compilation.] | Caspary, Vera, 1899-1987. Laura | Eustis, Helen. The horizontal man | Hughes, Dorothy B. (Dorothy Belle), 1904-1993. In a lonely place

Notice that you can play with another sort of combination
Comment 4 Danielle Elder 2016-04-29 22:06:16 UTC Comment hidden (obsolete)
Comment 5 Danielle Elder 2016-04-29 22:15:03 UTC
Thanks for the quick response, Héctor.
Comment 6 Héctor Eduardo Castro Avalos 2016-05-02 21:18:40 UTC
Created attachment 51118 [details]
Two MARC21 records to test with multiples 7XX fields
Comment 7 Héctor Eduardo Castro Avalos 2016-05-02 21:29:11 UTC Comment hidden (obsolete)
Comment 8 Héctor Eduardo Castro Avalos 2016-05-02 21:35:26 UTC
(In reply to Danielle Elder from comment #5)
> Thanks for the quick response, Héctor.

Hi Danielle

I attach a new patch with more changes, I've included new things to the patch, fix some mistake and also added the changes to Intranet and OPAC results.

There is a new marc file with two records, staged for test purposes.

Tanks for you test and sign-off

Regards
Comment 9 Héctor Eduardo Castro Avalos 2016-05-02 21:36:48 UTC
(In reply to Héctor Eduardo Castro Avalos from comment #8)
> 
> Tanks for you test and sign-off

Please re-test and re-sing-off
Comment 10 Danielle Elder 2016-05-04 14:39:49 UTC
Ok. I am going to retest and check Intranet this time. I only checked OPAC first test.
Comment 11 Héctor Eduardo Castro Avalos 2016-05-04 14:45:33 UTC Comment hidden (obsolete)
Comment 12 Héctor Eduardo Castro Avalos 2016-05-04 14:47:25 UTC
Hi Danielle

I rebase the patch with some typos fixed
Sorry for the inconvenience
Comment 13 Danielle Elder 2016-05-04 20:21:39 UTC Comment hidden (obsolete)
Comment 14 Danielle Elder 2016-05-04 20:38:48 UTC Comment hidden (obsolete)
Comment 15 Danielle Elder 2016-05-04 20:45:07 UTC
I tested the css classes and ordering in Intranet and OPAC. Looked great. I signed off.
Comment 16 Héctor Eduardo Castro Avalos 2016-05-05 19:27:10 UTC
Hi Danielle, you forgot to change the bug status
Comment 17 Danielle Elder 2016-05-05 19:58:00 UTC
Status is signed off.  Do you mean in giz bz? (I am a novice here, so let me know).
Comment 18 Katrin Fischer 2016-05-08 10:45:45 UTC
Hi Hector,
thx a lot for taking the time to work on this!
Reading the XSLT is quite hard, but in my tests it looked alright.
I am not sure this was the way of fix Winona had thought of - I'd love to get her opinion.
Comment 19 Katrin Fischer 2016-05-08 10:57:49 UTC
Is it intentional to not display 100$t any longer with this patch? Can you please check? It displays without this patch, 700$t displays with and without, but sequence is fixed.
Comment 20 Katrin Fischer 2016-05-08 13:23:00 UTC
*** Bug 16475 has been marked as a duplicate of this bug. ***
Comment 21 Héctor Eduardo Castro Avalos 2016-05-09 02:57:45 UTC
(In reply to Katrin Fischer from comment #19)
> Is it intentional to not display 100$t any longer with this patch? Can you
> please check? It displays without this patch, 700$t displays with and
> without, but sequence is fixed.

Hi Katrin. I intencional did it since subfield $t is only used in 7XX fields in MARC bibliographic. This subfield is only used in MARC authority. If a librarian use some authorized access point with $t (name-title) subfield in bib record, the uniform title is placed in 240$a field. But if some library use 1XX$t I can include it.

Regards

PS: This is a policy that Library of Congress don't want to change neither LCRI nor LC-PCC PS
Comment 22 Katrin Fischer 2016-05-19 05:15:48 UTC
Created attachment 51613 [details] [review]
[PASSED QA] Bug 16343: 7XX XSLT subfields displaying out of order

This patch respect previous css classes
.authordates and .relatorcode but also include .titleportion

.authordates {display: none;}
.titleportion {display: none;}
.relatorcode {display: none;}

To test:
- Stage the two record attached with titles:
  - Surface & coatings technology.
  - Women crime writers.
- Reindex zebra (necessary to Opac and Itranet results)
- Leave empty the OPACUserCSS and IntranetUserCSS sysprefs
- Go to the new records in OPAC and Intranet detail page
- See the wrong display of dates
- Apply patch and refresh the page
- Test in OPACUserCSS and IntranetUserCSS the css stated before
- Play deleting or adding the classes
- Test with multiple records with 700 (with and without dates, etc;
  710 and 711)

NOTE: dates in 710 and 711 can be hidden with .titleportion class;
dates in this kind of heading go with another data for example:
Catholic Church. Plenary Council of Baltimore (2nd : 1866)
Patch rebased some typos fixed in comments

Signed-off-by: Dani Elder <danielle@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 23 Kyle M Hall 2016-05-23 17:24:49 UTC
Pushed to master for Koha 16.05, thanks Hector!
Comment 24 Julian Maurice 2016-06-09 08:05:04 UTC
Patch pushed to 3.22.x, will be in 3.22.8