This patch http://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=installer/data/mysql/updatedatabase.pl;h=1f1c5a0d60024e11037fb3aff38ee0ed45460d1f;hp=57c83db612be4d218e9d1fef85003db1dfa0ce24;hb=ee652b07cabe58ae10fb77f69488dbd1a74bf962;hpb=9b866b91affb4e96cf2bc0a3b66bb638ddc54986 seems to cause: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'ALTER TABLE edifact_messages ...
Created attachment 50779 [details] [review] Bug 16361: Installer syntax error Bug 16354 introduces a syntax error on updatedatabase.pl see comment #5 there To test 1) Check error on update 3.23.00.051 2) Apply the patch 3) run updatedabase again (perhaps changing 051 to XXX)
Created attachment 50780 [details] [review] Bug 16361 - syntax error in updatedatabase To test: Set version below 3.23.00.051 (if necessary - you can do this in the localuse preferences in the intranet) Run the updatedatabase in your favourite way There should be no errors.
Comment on attachment 50780 [details] [review] Bug 16361 - syntax error in updatedatabase You beat me :)
Created attachment 50782 [details] [review] Bug 16361: Installer syntax error Bug 16354 introduces a syntax error on updatedatabase.pl see comment #5 there To test 1) Check error on update 3.23.00.051 2) Apply the patch 3) run updatedabase again (perhaps changing 051 to XXX) Signed-off-by: Liz Rea <liz@catalyst.net.nz> happy again!
(In reply to Liz Rea from comment #3) > > You beat me :) Yours was prettier :)
awww, hugs all around. :)
http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4e6baf61858bd22d91d50ad5f176f04242a23370 With this patch we don't get this message, caused by the above patch: [Wed Apr 27 14:50:11 2016] updatedatabase.pl: Not a CODE reference at /home/liz/koha-src/koha/installer/data/mysql/updatedatabase.pl line 12355.
(In reply to Liz Rea from comment #7) > http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff; > h=4e6baf61858bd22d91d50ad5f176f04242a23370 > > With this patch we don't get this message, caused by the above patch: > > [Wed Apr 27 14:50:11 2016] updatedatabase.pl: Not a CODE reference at > /home/liz/koha-src/koha/installer/data/mysql/updatedatabase.pl line 12355. Brendan beat us two, and it's pushed :) Resolved -> Fixed?
Nope, his one is still broken. :(
(In reply to Liz Rea from comment #9) > Nope, his one is still broken. :( Yeap, a missing 'do'
Created attachment 50786 [details] [review] [PASSED QA] Bug 16361: Installer syntax error Bug 16354 introduces a syntax error on updatedatabase.pl see comment #5 there To test 1) Check error on update 3.23.00.051 2) Apply the patch 3) run updatedabase again (perhaps changing 051 to XXX) Signed-off-by: Liz Rea <liz@catalyst.net.nz> happy again! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Hi Brendan, we are still missing a 'do' in the last updatedatabase entry: -$dbh->(q{ +$dbh->do(q{ I have passed the patch here - so you can either fix it directly or revert the last commit and use this patch here.
Pushed to Master - Should be in the May 2016 Release. Thanks!
Not needed in stable versions, status changed to RESOLVED