Bug 16499 - circulation.pl logs warnings about Use of uninitialized value
Summary: circulation.pl logs warnings about Use of uninitialized value
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 14015
Blocks:
  Show dependency treegraph
 
Reported: 2016-05-11 14:05 UTC by Jonathan Druart
Modified: 2016-12-05 21:25 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl (1.76 KB, patch)
2016-05-11 14:07 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl (1.87 KB, patch)
2016-05-11 14:34 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl (1.91 KB, patch)
2016-05-20 06:30 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl (1.87 KB, patch)
2016-05-23 17:35 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 16499 [QA Followup] - Improve readability (1.36 KB, patch)
2016-05-23 17:35 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-05-11 14:05:48 UTC
If you search for a patron in the circulation module, you get:

Use of uninitialized value $barcode in string eq at /home/koha/src/circ/circulation.pl line 84.
Use of uninitialized value $restoreduedatespec in string eq at /home/koha/src/circ/circulation.pl line 170.
Comment 1 Jonathan Druart 2016-05-11 14:07:54 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2016-05-11 14:34:31 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2016-05-20 06:30:08 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2016-05-23 17:35:12 UTC
Created attachment 51721 [details] [review]
Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl

If you search for a patron in the circulation module, you get:

Use of uninitialized value $barcode in string eq at
/home/koha/src/circ/circulation.pl line 84.
Use of uninitialized value $restoreduedatespec in string eq at
/home/koha/src/circ/circulation.pl line 170.

Test plan:
- Search for a patron and confirm the warnings are not displayed anymore
- Make sure this patch does not introduce regression on bug 14015

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Kyle M Hall 2016-05-23 17:35:19 UTC
Created attachment 51722 [details] [review]
Bug 16499 [QA Followup] - Improve readability
Comment 6 Kyle M Hall 2016-05-23 17:35:48 UTC
Pushed to master for 16.05, thanks Jonathan!
Comment 7 Julian Maurice 2016-05-25 09:34:51 UTC
Patches pushed to 3.22.x, will be in 3.22.7