Created attachment 52951 [details] [review] Bug 16836: Document unused parameters of SearchAuthorities Two parameters $and_or and $excluding are not used. Test plan: Run t/db_dependent/Search.t
If you query $ git grep 'SearchAuthorities' There are some lines that use the two parameters, maybe exist more: authorities/auth_finder.pl: SearchAuthorities( \@marclist, \@and_or, \@excluding, \@operator, \@value, authorities/authorities-home.pl: #my ( $results, $total ) = SearchAuthorities( authorities/ysearch.pl: my ( $results, $total ) = SearchAuthorities( \@marclist, \@and_or, \@excluding, \@operator, \@value, $startfrom * $resultsperpage, $resultsperpage, $authtypecode, $orderby ); cataloguing/value_builder/unimarc_field_210c.pl:###TODO To rewrite in order to use SearchAuthorities cataloguing/value_builder/unimarc_field_210c.pl: my ($results,$total) = SearchAuthorities( \@tags,\@and_or, cataloguing/value_builder/unimarc_field_225a.pl: my ($results,$total) = SearchAuthorities( \@tags,\@and_or, Regards
(In reply to Héctor Eduardo Castro Avalos from comment #2) > If you query $ git grep 'SearchAuthorities' > > > There are some lines that use the two parameters, maybe exist more: > > > authorities/auth_finder.pl: SearchAuthorities( \@marclist, \@and_or, > \@excluding, \@operator, \@value, > authorities/authorities-home.pl: #my ( $results, $total ) = > SearchAuthorities( > authorities/ysearch.pl: my ( $results, $total ) = SearchAuthorities( > \@marclist, \@and_or, \@excluding, \@operator, \@value, $startfrom * > $resultsperpage, $resultsperpage, $authtypecode, $orderby ); > cataloguing/value_builder/unimarc_field_210c.pl:###TODO To rewrite in order > to use SearchAuthorities > cataloguing/value_builder/unimarc_field_210c.pl: my ($results,$total) > = SearchAuthorities( \@tags,\@and_or, > cataloguing/value_builder/unimarc_field_225a.pl: my ($results,$total) = > SearchAuthorities( \@tags,\@and_or, > > Regards Hello Hector, That is true. The parameters are passed to the routine, but they actually do nothing. This patch makes that fact more visible without having to change all calls of the routine. Note that this allows someone to adjust the routine to do something useful with these parameters. Marcel
Time goes by