Bug 17171 - Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation
Summary: Add a syspref to allow currently issued items to be issued to a new patron wi...
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-23 15:58 UTC by Nick Clemens
Modified: 2017-08-11 18:55 UTC (History)
7 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 17171 - Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation (10.30 KB, patch)
2017-06-13 14:28 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 17171 - Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation (10.12 KB, patch)
2017-08-11 18:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 17171 - Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation (10.24 KB, patch)
2017-08-11 18:55 UTC, ByWaterSandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2016-08-23 15:58:20 UTC
Work to be done:
1) Add new system preference AutoReturnCheckedOutItemForNewCheckout ( or something more terse )
2) Add new system preference AutoReturnCheckedOutItemForNewCheckoutForgiveFine
3) Modify circulation.pl to accept these new parameters and report what happened (yellow box) instead of prompting for confirmation
Comment 1 Katrin Fischer 2016-08-23 21:01:57 UTC
AutoReturnCheckedOutItemForNewCheckoutForgiveFine

It looks a bit like all the Koha buzz words in one word :) Could we find something a bit shorter?
Comment 2 Kyle M Hall 2017-06-13 14:28:38 UTC
Created attachment 64260 [details] [review]
Bug 17171 - Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation

Some libraries don't want to force the librarians to manually confirm
each checkout when the item is checked out to another. Instead, they
would prefer to be alerted after the fact.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable the new syspref AutoReturnCheckedOutItems
4) Check an item out to a patron
5) Check the same item out to another patron
6) Note you are not prompted to confirm the checkout,
   but are instead alerted that is had been checked out to another patron!
Comment 3 Christopher Brannon 2017-08-11 18:08:34 UTC
Patch does not apply.
Comment 4 Kyle M Hall 2017-08-11 18:25:19 UTC
Created attachment 65924 [details] [review]
Bug 17171 - Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation

Some libraries don't want to force the librarians to manually confirm
each checkout when the item is checked out to another. Instead, they
would prefer to be alerted after the fact.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable the new syspref AutoReturnCheckedOutItems
4) Check an item out to a patron
5) Check the same item out to another patron
6) Note you are not prompted to confirm the checkout,
   but are instead alerted that is had been checked out to another patron!
Comment 5 Christopher Brannon 2017-08-11 18:53:38 UTC
The syspref worked when set to Don't.  That was the only confusion in the test plan.  Otherwise, works as expected!
Comment 6 ByWaterSandboxes 2017-08-11 18:55:18 UTC
Patch tested with a sandbox, by Christopher Brannon <cbrannon@cdalibrary.org>
Comment 7 ByWaterSandboxes 2017-08-11 18:55:34 UTC
Created attachment 65925 [details] [review]
Bug 17171 - Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation

Some libraries don't want to force the librarians to manually confirm
each checkout when the item is checked out to another. Instead, they
would prefer to be alerted after the fact.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable the new syspref AutoReturnCheckedOutItems
4) Check an item out to a patron
5) Check the same item out to another patron
6) Note you are not prompted to confirm the checkout,
   but are instead alerted that is had been checked out to another patron!

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com>