Bug 17277 - Current Location column in Holdings table showing empty under OPAC
Summary: Current Location column in Holdings table showing empty under OPAC
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Tomás Cohen Arazi
URL:
Whiteboard:
Keywords:
Depends on: 4941 7720
Blocks: 16759
  Show dependency treegraph
 
Reported: 2016-09-08 12:10 UTC by Erjon Sulaj
Modified: 2017-10-25 15:18 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
item details opac (36.40 KB, image/png)
2016-09-08 12:10 UTC, Erjon Sulaj
Details
Koha current location (130.40 KB, application/pdf)
2016-11-10 07:13 UTC, Felix Hemme
Details
Bug 17277: Always display location and *branch item info - opac detail (9.11 KB, patch)
2017-07-12 12:33 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 17277: Always display location and *branch item info - opac detail (9.16 KB, patch)
2017-08-04 13:17 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 17277: Always display location and *branch item info - opac detail (9.21 KB, patch)
2017-08-04 19:25 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Erjon Sulaj 2016-09-08 12:10:09 UTC
Created attachment 55333 [details]
item details opac

Hi, for a couple of days I tried to resolve the problem by double checking the cataloging process, or item details, but at no avail. 

The problem is that the holdings detail table does not show anything under the "current location" field when accessing item details under OPAC, while it shows all the details if accessed from staff interface. 

I am attaching the pictures for what I stated above. 

Best regards,
Comment 1 Owen Leonard 2016-09-08 15:19:22 UTC
I cannot reproduce this problem in version 16.05 or in the master branch. It seems likely that this is a data or configuration issue. I suggest bringing it to the Koha mailing list to see if anyone there has suggestions.
Comment 2 Felix Hemme 2016-11-10 07:12:20 UTC
The error occurs, if you have just one library defined in system administration. To reproduce:

1. Make sure you have one library defined.
2. Catalog any title and attach an item
3. Check current location in your OPAC - nothing is shown
4. Add a second library in system administration
5. Check current location again - now it's displayed

See images attached.
Comment 3 Felix Hemme 2016-11-10 07:13:42 UTC
Created attachment 57410 [details]
Koha current location
Comment 4 Katrin Fischer 2016-11-10 07:20:06 UTC
Hm, I am not sure if this was an intended effect caused by the removal of the SingleBranch system preference. Does it still show locations (LOC)?
Comment 5 Felix Hemme 2016-11-10 07:30:05 UTC
(In reply to Katrin Fischer from comment #4)
> Hm, I am not sure if this was an intended effect caused by the removal of
> the SingleBranch system preference. Does it still show locations (LOC)?

Yes, locations are still displayed.
Comment 6 Jonathan Druart 2016-11-10 09:24:02 UTC
(In reply to Katrin Fischer from comment #4)
> Hm, I am not sure if this was an intended effect caused by the removal of
> the SingleBranch system preference.

No I don't think it comes from bug 4941.
Comment 7 Liz Rea 2017-07-10 23:18:05 UTC
I've seen this too now, on 16.11.08

Adding a dummy branch fixes it.
Comment 8 Katrin Fischer 2017-07-11 04:46:08 UTC
Hi Liz, so it appears when there is no branch set at all?
Comment 9 Jonathan Druart 2017-07-11 16:56:26 UTC
Ok, recreated.

What happens:
If there is only 1 library defined we only display items.location. If it is not mapped, it is empty.
If there is more than 1 library defined, we display items.*branch (depending on OpacLocationBranchToDisplay) AND items.location.

I have no idea what the fix could be.
Comment 10 Katrin Fischer 2017-07-11 18:19:46 UTC
I think this was intentional - it's the behaviour as it was with SingleBranchLibrary, that was removed in favour of checking for the number of branches in a library.
Comment 11 Liz Rea 2017-07-11 21:57:44 UTC
I'm reminded of this: 

https://xkcd.com/1172/

So basically, we should tell single branch libraries to add a location to all of their items, otherwise that column looks weirdly empty.

Or we should check to see if any items have locations, and not display the column if no items have it.

What do you think?
Comment 12 Katrin Fischer 2017-07-12 07:02:15 UTC
Maybe intentional, but not well thought through. - The second one is better, of course. Would we also want to change the column name in those cases? Not sure what it reads now.
Comment 13 Jonathan Druart 2017-07-12 12:29:58 UTC
What about removing the UNLESS singleBranchMode condition? It will display both the location and the *branch in any cases.
Comment 14 Jonathan Druart 2017-07-12 12:33:37 UTC
Created attachment 65008 [details] [review]
Bug 17277: Always display location and *branch item info - opac detail
Comment 15 Liz Rea 2017-07-13 02:26:10 UTC
I just don't know - not showing the branch for a single branch is I think, a good change.

For libraries that don't also have locations in (all of) their records, it can be quite awkward looking in the OPAC.

Really not sure how best to go about appeasing all of the different ways libraries want to show this data. I'd say "add a preference" except that's annoying - we have so many already. I'd say "use CSS or jquery to hide it" but that's inaccessible or much harder for lots of library staff who are in charge of a Koha.

Putting it all back the way it was before is appealing, but also meh because it'll break someone's wishes somewhere.

Maybe it's best to make an actual preference for "single branch mode" to specify that single branch mode is an actual settable "mode" and not something we've intuited based on the number of branches. 

So hard! Arg!
Comment 16 Michael Kuhn 2017-07-24 21:28:59 UTC
Another finding:

As described, if there is only one single library branch in the OPAC the holdings detail table doesn't show anything in the "current location" field of any single hit.

But if you click the "MARC" tab of that same single hit the holdings detail table at the end of the MARC listing DOES show the "current location".

I don't see any reason why to display an empty field instead of the "current location" at one place but displaying (or creating) its content at another place. If the system can't display its content the field shouldn't be there at all.

However - as suggested by Liz Rea - easiest way to fix the problem is adding a second (dummy) library branch.
Comment 17 Katrin Fischer 2017-07-24 21:32:50 UTC
What shows in the MARC view or not is configured in the MARC bibliographic frameworks to the preference of the library.
Comment 18 Owen Leonard 2017-08-04 13:17:21 UTC
Created attachment 65499 [details] [review]
[SIGNED-OFF] Bug 17277: Always display location and *branch item info - opac detail

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 19 Owen Leonard 2017-08-04 13:18:01 UTC
Considering Bug 16759 I think this patch is the right solution.
Comment 20 Tomás Cohen Arazi 2017-08-04 19:25:36 UTC
Created attachment 65514 [details] [review]
Bug 17277: Always display location and *branch item info - opac detail

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 21 Jonathan Druart 2017-08-09 16:37:44 UTC
Liz, Katrin, do you agree with this patch?
Comment 22 Katrin Fischer 2017-08-10 10:19:13 UTC
I thought that when there is only one library, showing the library on each item was not necessary. We even had libraries asking to remove the branch information from the staff side as well, because they felt it was taking up space unnecessarily. But from the comments it appears that not every library shares this view.

Even with bug 16759 I think we won't quite get the current or ideal behaviour (only show the column, if there is a location (LOC) for the item defined).

But it might be a step forward to find other ways of resolving this.
Comment 23 Liz Rea 2017-08-11 02:56:46 UTC
I'm really not sure. The column hiding thing only works if you want ALL of it gone. What if you still want to see the location but not the branch?
Comment 24 Katrin Fischer 2017-08-11 08:37:24 UTC
Liz is correct about this, the current behaviour won't be brought back by bug 16759.
Comment 25 Owen Leonard 2017-08-11 13:24:31 UTC
(In reply to Liz Rea from comment #23)
> What if you still want to see the location but not the branch?

Bug 19028?
Comment 26 Jonathan Druart 2017-08-15 14:42:20 UTC
So a plan would be to push bug 19028, bug 16759 and this one altogether?
Comment 27 Liz Rea 2017-08-15 22:16:07 UTC
Comment on attachment 57410 [details]
Koha current location

I think that's alright, yes.
Comment 28 Jonathan Druart 2017-10-25 15:18:04 UTC
Pushed to master for 17.11, thanks to everybody involved!