Bug 17381 - Add system preference SCOMainUserBlock
Summary: Add system preference SCOMainUserBlock
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 12691
Blocks:
  Show dependency treegraph
 
Reported: 2016-09-30 06:36 UTC by Marc Véron
Modified: 2017-10-26 00:25 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 17381: Add system preference SCOMainUserBlock (5.42 KB, patch)
2017-04-18 14:04 UTC, Marc Véron
Details | Splinter Review
[SIGNED-OFF] Bug 17381: Add system preference SCOMainUserBlock (5.49 KB, patch)
2017-05-22 11:27 UTC, Josef Moravec
Details | Splinter Review
Bug 17381: Add system preference SCOMainUserBlock (4.48 KB, patch)
2017-08-21 13:29 UTC, Marc Véron
Details | Splinter Review
[SIGNED-OFF] Bug 17381: Add system preference SCOMainUserBlock (4.55 KB, patch)
2017-08-22 11:10 UTC, Josef Moravec
Details | Splinter Review
Bug 17381: Add system preference SCOMainUserBlock (4.59 KB, patch)
2017-10-24 15:47 UTC, Nick Clemens
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2016-09-30 06:36:37 UTC
Add a system preference SCOUserHTML to display content on the self checkout page.
Comment 1 Agnes Rivers-Moore 2017-01-12 17:27:42 UTC
I would love this - just setting up SCO and noted the need for a bit more on screen help.
Comment 2 Agnes Rivers-Moore 2017-01-12 17:33:08 UTC
I would love this option! Just setting up SCO and noted the need for a bit more user interface on screen help. It could be Library specific, so an HTML section would be very useful.
I have help until end March 2017 - if anyone has time to introduce him to the code used we might be able to contribute, or to test.
I would also like to change the text of the Print prompt - Cancel or OK is not very helpful in answer to "Do you want to print?"
Comment 3 Katrin Fischer 2017-01-18 00:04:36 UTC
Hi Agnes, maybe sent them to the IRC chat - there is almost always someone around to help out and answer questions. 
For a development setup, you can point them to https://github.com/digibib/kohadevbox. For other information on the development process the wiki is a helpful resource, especially the pages linked to the Developer handbook: https://wiki.koha-community.org/wiki/Developer_handbook.
Good luck!
Comment 4 Marc Véron 2017-04-18 14:04:45 UTC
Created attachment 62295 [details] [review]
Bug 17381: Add system preference SCOMainUserBlock

This patch adds a system preference SCOMainUserBlock to display custom HTML
on the self checkout page.

To test:
- Set up self checkout (see section Self Checkout in Circulaton sysprefs )
- Apply patch
- Update db
- Add some HTML system preference SCOMainUserBlock
- Go to sco page
- Verify that HTML displays on page (logged in and not logged in)
Comment 5 Marc Véron 2017-05-18 07:16:28 UTC
Still applies on current master
Comment 6 Josef Moravec 2017-05-22 11:27:05 UTC
Created attachment 63611 [details] [review]
[SIGNED-OFF] Bug 17381: Add system preference SCOMainUserBlock

This patch adds a system preference SCOMainUserBlock to display custom HTML
on the self checkout page.

To test:
- Set up self checkout (see section Self Checkout in Circulaton sysprefs )
- Apply patch
- Update db
- Add some HTML system preference SCOMainUserBlock
- Go to sco page
- Verify that HTML displays on page (logged in and not logged in)

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 7 Nick Clemens 2017-07-31 16:44:07 UTC
Hi Marc,

1 - I am not sure where that closing div goes - #newcheckout does seem to close properly unless I missed something

2 - Why not use Koha.Preference TT plugin instead of passing the pref?

-Nick
Comment 8 Marc Véron 2017-07-31 17:24:31 UTC Comment hidden (obsolete)
Comment 9 Marc Véron 2017-08-03 10:02:02 UTC
I was not aware of  Bug 12691 - Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout

Will re-write that 17381 on top of 12691.
Comment 10 Marc Véron 2017-08-21 13:29:53 UTC
Created attachment 66271 [details] [review]
Bug 17381: Add system preference SCOMainUserBlock

This patch adds a system preference SCOMainUserBlock to display custom HTML
on the self checkout page.

To test:
- Set up self checkout (see section Self Checkout in Circulaton sysprefs )
- Apply patch
- Update db
- Add some HTML system preference SCOMainUserBlock
- Go to sco page
- Verify that HTML displays on page (logged in and not logged in)

New version based on Koha.Preference TT plugin as of comment #7
Depends on Bug 12691
Comment 11 Josef Moravec 2017-08-22 11:10:04 UTC
Created attachment 66322 [details] [review]
[SIGNED-OFF] Bug 17381: Add system preference SCOMainUserBlock

This patch adds a system preference SCOMainUserBlock to display custom HTML
on the self checkout page.

To test:
- Set up self checkout (see section Self Checkout in Circulaton sysprefs )
- Apply patch
- Update db
- Add some HTML system preference SCOMainUserBlock
- Go to sco page
- Verify that HTML displays on page (logged in and not logged in)

New version based on Koha.Preference TT plugin as of comment #7
Depends on Bug 12691

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 12 Nick Clemens 2017-10-24 15:47:10 UTC
Created attachment 68481 [details] [review]
Bug 17381: Add system preference SCOMainUserBlock

This patch adds a system preference SCOMainUserBlock to display custom HTML
on the self checkout page.

To test:
- Set up self checkout (see section Self Checkout in Circulaton sysprefs )
- Apply patch
- Update db
- Add some HTML system preference SCOMainUserBlock
- Go to sco page
- Verify that HTML displays on page (logged in and not logged in)

New version based on Koha.Preference TT plugin as of comment #7
Depends on Bug 12691

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 13 Jonathan Druart 2017-10-25 15:18:19 UTC
Pushed to master for 17.11, thanks to everybody involved!
Comment 14 Agnes Rivers-Moore 2017-10-26 00:25:30 UTC
Thank you everyone!