Bug 17574 - Remove LocalholdsPriority.t warnings
Summary: Remove LocalholdsPriority.t warnings
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 14598
Blocks:
  Show dependency treegraph
 
Reported: 2016-11-07 18:32 UTC by Tomás Cohen Arazi
Modified: 2018-06-04 20:10 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 17574: Remove itemtype-related warnings from LocalHoldsPriority.t (2.29 KB, patch)
2016-11-07 18:35 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 17574: Remove itemtype-related warnings from LocalHoldsPriority.t (2.36 KB, patch)
2016-11-07 21:33 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 17574: Remove itemtype-related warnings from LocalHoldsPriority.t (2.44 KB, patch)
2016-11-11 08:18 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2016-11-07 18:32:42 UTC
Bug 14598 made this tests raise lots of warnings because of incomplete data on sample items.
Comment 1 Tomás Cohen Arazi 2016-11-07 18:35:30 UTC
Created attachment 57277 [details] [review]
Bug 17574: Remove itemtype-related warnings from LocalHoldsPriority.t

To test:
- Run:
  $ prove t/db_dependent/Holds/LocalHoldsPriority.t
=> FAIL: Tests raise lots of warnings
- Apply the patch
- Run:
  $ prove t/db_dependent/Holds/LocalHoldsPriority.t
=> SUCCESS: Tests pass, and no warnings!
- Sign off :-D

Sponsored-by: ByWater Solutions
Comment 2 Josef Moravec 2016-11-07 21:33:33 UTC
Created attachment 57288 [details] [review]
[SIGNED-OFF] Bug 17574: Remove itemtype-related warnings from LocalHoldsPriority.t

To test:
- Run:
  $ prove t/db_dependent/Holds/LocalHoldsPriority.t
=> FAIL: Tests raise lots of warnings
- Apply the patch
- Run:
  $ prove t/db_dependent/Holds/LocalHoldsPriority.t
=> SUCCESS: Tests pass, and no warnings!
- Sign off :-D

Sponsored-by: ByWater Solutions

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 3 Marcel de Rooy 2016-11-11 08:18:59 UTC
Created attachment 57448 [details] [review]
Bug 17574: Remove itemtype-related warnings from LocalHoldsPriority.t

To test:
- Run:
  $ prove t/db_dependent/Holds/LocalHoldsPriority.t
=> FAIL: Tests raise lots of warnings
- Apply the patch
- Run:
  $ prove t/db_dependent/Holds/LocalHoldsPriority.t
=> SUCCESS: Tests pass, and no warnings!
- Sign off :-D

Sponsored-by: ByWater Solutions

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Kyle M Hall 2016-11-12 02:35:34 UTC
Pushed to master for 16.11, thanks Tomas!
Comment 5 Mason James 2016-12-14 10:48:11 UTC
Pushed to 16.05.x, for 16.05.06 release