Bug 17637 - Auth_with_ldap.t is failing
Summary: Auth_with_ldap.t is failing
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-16 07:43 UTC by Jonathan Druart
Modified: 2016-12-14 11:16 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 17637: Fix tests Auth_with_ldap.t (2.49 KB, patch)
2016-11-16 07:46 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 17637: Fix tests Auth_with_ldap.t (2.55 KB, patch)
2016-11-16 11:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 17637: Fix tests Auth_with_ldap.t (1.37 KB, patch)
2016-11-16 13:27 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-11-16 07:43:40 UTC

    
Comment 1 Jonathan Druart 2016-11-16 07:46:26 UTC
Created attachment 57522 [details] [review]
Bug 17637: Fix tests Auth_with_ldap.t

Koha::Patron->delete create a transaction and so we need to use
txn_begin to have nested txn

DBD::mysql::db begin_work failed: Already in a transaction
Comment 2 Kyle M Hall 2016-11-16 11:25:15 UTC
Created attachment 57538 [details] [review]
Bug 17637: Fix tests Auth_with_ldap.t

Koha::Patron->delete create a transaction and so we need to use
txn_begin to have nested txn

DBD::mysql::db begin_work failed: Already in a transaction

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 3 Tomás Cohen Arazi 2016-11-16 13:27:56 UTC
Created attachment 57544 [details] [review]
Bug 17637: Fix tests Auth_with_ldap.t

Koha::Patron->delete create a transaction and so we need to use
txn_begin to have nested txn

DBD::mysql::db begin_work failed: Already in a transaction

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Kyle M Hall 2016-11-16 14:02:07 UTC
Pushed to master for 16.11, thanks Jonathan!
Comment 5 Mason James 2016-12-14 11:16:04 UTC
Pushed to 16.05.x, for 16.05.06 release