To replicate: Add a note to a field in a record (let's say 500) Verify the note shows in both the OPAC Detail and OPAC MARC views Add a blacklist entry to the NotesBlacklist system preference for field 500 Verify the note does not appear on the OPAC detail Verify the note DOES appear on the OPAC MARC detail. Blacklisted notes shouldn't display anywhere in the OPAC.
I am not sure about this. I think the hidden value in the MARC frameworks take care of this now, so maybe just a matter of making the pref description more explicit?
Created attachment 97266 [details] [review] Bug 17697: Improve NotesBlacklist system preference description - Switched 'separator' for more common 'tab' and rephrased sentence - Added examples - Added note to use hidden settings for hiding in other spots. To test: - Search for NotesBlacklist system preference and read the description - Apply patch - Refresh and read again - If improved, sign off. https://bugs.koha-community.org/show_bug.cgi?id=24206
Created attachment 97946 [details] [review] Bug 17697: Improve NotesBlacklist system preference description - Switched 'separator' for more common 'tab' and rephrased sentence - Added examples - Added note to use hidden settings for hiding in other spots. To test: - Search for NotesBlacklist system preference and read the description - Apply patch - Refresh and read again - If improved, sign off. https://bugs.koha-community.org/show_bug.cgi?id=24206 Signed-off-by: David Nind <david@davidnind.com>
Reads much better to me! Made a very minor tweak - added an 'a' (changed 'Use comma..." to "Use a comma...").
Can I add a br tag before the last sentence?
Created attachment 98108 [details] [review] Bug 17697: Improve NotesBlacklist system preference description - Switched 'separator' for more common 'tab' and rephrased sentence - Added examples - Added note to use hidden settings for hiding in other spots. To test: - Search for NotesBlacklist system preference and read the description - Apply patch - Refresh and read again - If improved, sign off. https://bugs.koha-community.org/show_bug.cgi?id=24206 Signed-off-by: David Nind <david@davidnind.com>
(In reply to Jonathan Druart from comment #5) > Can I add a br tag before the last sentence? Added.
Created attachment 98109 [details] [review] Bug 17697: Improve NotesBlacklist system preference description - Switched 'separator' for more common 'tab' and rephrased sentence - Added examples - Added note to use hidden settings for hiding in other spots. To test: - Search for NotesBlacklist system preference and read the description - Apply patch - Refresh and read again - If improved, sign off. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.03
backported to 19.05.x for 19.05.08