There is a $item_format which is never used.
Created attachment 59410 [details] [review] Bug 17968: Remove useless variable $item_format in C4::Overdues::parse_overdues_letter The variable $item_format is not used and should be removed from this subroutine. Moreover it the letter parameter, but it is never sent to this subroutine. letter_code is expected instead. Test plan: No test plan, just read the code and `git grep `
(In reply to Jonathan Druart from comment #1) > Moreover it the letter parameter, but it is never sent to this > subroutine. letter_code is expected instead. Right, $params->{letter}->{content} is never used, so while the logic actually does something, it isn't actually used at all. > Test plan: > No test plan, just read the code and `git grep ` Oh, and there is just the letter_code sent and expected.
Created attachment 59484 [details] [review] Bug 17968: Remove useless variable $item_format in C4::Overdues::parse_overdues_letter The variable $item_format is not used and should be removed from this subroutine. Moreover it the letter parameter, but it is never sent to this subroutine. letter_code is expected instead. Test plan: No test plan, just read the code and `git grep ` Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 59602 [details] [review] Bug 17968: Remove useless variable $item_format in C4::Overdues::parse_overdues_letter The variable $item_format is not used and should be removed from this subroutine. Moreover it the letter parameter, but it is never sent to this subroutine. letter_code is expected instead. Test plan: No test plan, just read the code and `git grep ` Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.05, thanks Jonathan!
This won't get ported back to 16.11.x as it is an enhancement.