Bug 18738 - Koha_Elasticsearch_Indexer.t fails if Elasticsearch is configured but not running
Summary: Koha_Elasticsearch_Indexer.t fails if Elasticsearch is configured but not run...
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Mark Tompsett
QA Contact: Galen Charlton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-06 16:08 UTC by Lee Jamison
Modified: 2020-08-19 06:45 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 18738: Improve failure cases to skip better (2.01 KB, patch)
2018-04-12 19:38 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 18738: Improve failure cases to skip better (1.98 KB, patch)
2018-04-13 02:31 UTC, Mark Tompsett
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lee Jamison 2017-06-06 16:08:49 UTC
When Elasticsearch is not configured/not running, executing

prove -v t/db_dependent/Koha_Elasticsearch_Indexer.t

fails with the same error message as indicated in Bug 12478

([NoNodes] ** No nodes are available: [http://localhost:9200], called from sub Search::Elasticsearch::Role::Client::Direct::__ANON__ at /usr/local/share/perl/5.10.1/Catmandu/Store/ElasticSearch.pm line 61)

Leaving the Elasticsearch koha-conf values empty creates same failure.
Comment 1 Mark Tompsett 2018-04-12 19:38:53 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2018-04-13 02:31:00 UTC
Created attachment 74121 [details] [review]
Bug 18738: Improve failure cases to skip better

TEST PLAN
---------
no elasticsearch section in koha-conf.xml
prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- nasty
elasticsearch, but no nodes
prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- ugly
apply patch
re-run above cases
-- unique skips
run qa test tools
Comment 3 Hayley Pelham 2019-03-08 02:39:14 UTC
Patch doesn't apply

Applying: Bug 18738: Improve failure cases to skip better
Using index info to reconstruct a base tree...
A	t/db_dependent/Koha_Elasticsearch_Indexer.t
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): t/db_dependent/Koha_Elasticsearch_Indexer.t deleted in HEAD and modified in Bug 18738: Improve failure cases to skip better. Version Bug 18738: Improve failure cases to skip better of t/db_dependent/Koha_Elasticsearch_Indexer.t left in tree.
error: Failed to merge in the changes.
Patch failed at 0001 Bug 18738: Improve failure cases to skip better
Comment 4 Katrin Fischer 2019-03-08 06:54:17 UTC
Hi Hayley, if a patch doesn't apply, you can use the status "Patch doesn't apply" . Thx for your testing!
Comment 5 Michal Denar 2019-07-09 20:17:06 UTC
Hi,
can author rebase this on master, please?

Thank you.