Bug 18832 - Missing space between icon and label in button 'Patron lists'
Summary: Missing space between icon and label in button 'Patron lists'
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Whiteboard:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2017-06-21 07:39 UTC by Marc Véron
Modified: 2017-07-17 19:13 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Screenshot with button 'Patron lists' (7.66 KB, image/png)
2017-06-21 07:39 UTC, Marc Véron
Details
Bug 18832: Missing space between icon and label in button 'Patron lists' (1.25 KB, patch)
2017-06-21 07:49 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 18832: Missing space between icon and label in button 'Patron lists' (1.30 KB, patch)
2017-06-28 13:40 UTC, sandboxes@biblibre.com
Details | Diff | Splinter Review
Bug 18832: Missing space between icon and label in button 'Patron lists' (1.37 KB, patch)
2017-07-07 08:02 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2017-06-21 07:39:40 UTC
Created attachment 64483 [details]
Screenshot with button 'Patron lists'

On page Home > Patrons the button 'Patron lists' misses a space between the Icon and the text. See screenshot attached.
Comment 1 Marc Véron 2017-06-21 07:49:38 UTC
Created attachment 64485 [details] [review]
Bug 18832: Missing space between icon and label in button 'Patron lists'

On page Home > Patrons the button 'Patron lists' misses a space between
icon and text. This patch adds it to make the button display like the other
ones.

To test, apply patch and verify that the button displays as expected.
Comment 2 Frederique Couffignal 2017-06-28 13:37:16 UTC
Space on button ok
Action on button is ok too
Comment 3 sandboxes@biblibre.com 2017-06-28 13:40:11 UTC
Patch tested with a sandbox, by fcouffignal <fcouffignal@gmail.com>
Comment 4 sandboxes@biblibre.com 2017-06-28 13:40:35 UTC
Created attachment 64702 [details] [review]
Bug 18832: Missing space between icon and label in button 'Patron lists'

On page Home > Patrons the button 'Patron lists' misses a space between
icon and text. This patch adds it to make the button display like the other
ones.

To test, apply patch and verify that the button displays as expected.

Signed-off-by: fcouffignal <fcouffignal@gmail.com>
Comment 5 Julian Maurice 2017-07-07 08:02:52 UTC
Created attachment 64890 [details] [review]
Bug 18832: Missing space between icon and label in button 'Patron lists'

On page Home > Patrons the button 'Patron lists' misses a space between
icon and text. This patch adds it to make the button display like the other
ones.

To test, apply patch and verify that the button displays as expected.

Signed-off-by: fcouffignal <fcouffignal@gmail.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 6 Jonathan Druart 2017-07-17 19:13:24 UTC
Pushed to master for 17.11, thanks to everybody involved!