Bug 18922 - Mana - Share review
Summary: Mana - Share review
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Web services (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Alex Arnaud
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 17047
Blocks:
  Show dependency treegraph
 
Reported: 2017-07-10 12:26 UTC by Baptiste
Modified: 2018-05-15 12:08 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 18922: Share review with Mana (10.28 KB, patch)
2017-07-10 12:42 UTC, Baptiste
Details | Diff | Splinter Review
Bug 18922: Dbix updates (2.84 KB, patch)
2017-07-10 12:43 UTC, Baptiste
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Baptiste 2017-07-10 12:26:53 UTC
This module add reviews for Mana
Comment 1 Baptiste 2017-07-10 12:42:48 UTC
Created attachment 64958 [details] [review]
Bug 18922: Share review with Mana

This add reviews sharing with Mana.

Test plan:
1 - Check Bug 17057 is installed and works on your Koha
2 - Apply patch
3 - Activate Review Sharing with Mana (AutoShareWithMana => review)
4 - Comment a resource of your database and check you authorize sharing with Mana
5 - As librarian, validate the comment
6 - If you go again on the notice you should see the comment
7 - Try again step 4-6 without accepting to share with Mana => it won't share

Note: The resource must have a valid isbn/issn/ean in the database field.
Comment 2 Baptiste 2017-07-10 12:43:05 UTC
Created attachment 64959 [details] [review]
Bug 18922: Dbix updates

This is the dbix update so you don't have to run the script.
Comment 3 Victor Grousset/tuxayo 2018-02-08 13:32:05 UTC
Baptiste doesn't work anymore at BibLibre.
Unassigning to avoid signaling that this bug is still being supervized. Which could wrongly discourage someone to continue the work.
Comment 4 Hugo Agud 2018-05-15 11:24:09 UTC
Using index info to reconstruct a base tree...
M	koha-tmpl/intranet-tmpl/prog/css/staff-global.css
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/css/staff-global.css
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/staff-global.css
Failed to merge in the changes.
Patch failed at 0001 Bug 19474: (follow-up) Compiled CSS
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-19474-follow-up-Compiled-CSS-hIYP0p.patch

Cannot apply cleanly patches from bug 19474. Everything will be left dirty.
git bz apply --continue will not continue the process if patches from other bug reports need to be applied.