Bug 19022 - Improve location and author display in inventory tool
Summary: Improve location and author display in inventory tool
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Fridolin SOMERS
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-02 08:41 UTC by Fridolin SOMERS
Modified: 2017-11-28 07:20 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19022 - inventory location and author display (1.92 KB, patch)
2017-08-02 08:52 UTC, Fridolin SOMERS
Details | Diff | Splinter Review
Screenshot with patch (201.16 KB, image/png)
2017-08-02 08:54 UTC, Fridolin SOMERS
Details
[SIGNED-OFF] Bug 19022 - inventory location and author display (1.98 KB, patch)
2017-08-02 13:40 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 19022 - inventory location and author display (2.02 KB, patch)
2017-10-27 14:53 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin SOMERS 2017-08-02 08:41:58 UTC
In inventory result page :
Location is displayed after branch without any difference.
Author is displayed into a paragraph making row hight.
Comment 1 Fridolin SOMERS 2017-08-02 08:52:02 UTC
Created attachment 65414 [details] [review]
Bug 19022 - inventory location and author display

In inventory result page :
Location is displayed after branch without any difference.
Author is displayed into a paragraph making row hight.

This patch adds for location a span with class like in catalogue detail page, and changes author to be on same line in order to have a more compact display for this table that may be huge.

Test plan :
- Perform inventory with a barcode file
- Look at result
=> you see localtion in a new line after library and in italic
=> you see author after title on same line with "by" separator
Comment 2 Fridolin SOMERS 2017-08-02 08:54:57 UTC
Created attachment 65415 [details]
Screenshot with patch
Comment 3 Owen Leonard 2017-08-02 13:40:54 UTC
Created attachment 65425 [details] [review]
[SIGNED-OFF] Bug 19022 - inventory location and author display

In inventory result page :
Location is displayed after branch without any difference.
Author is displayed into a paragraph making row hight.

This patch adds for location a span with class like in catalogue detail page, and changes author to be on same line in order to have a more compact display for this table that may be huge.

Test plan :
- Perform inventory with a barcode file
- Look at result
=> you see localtion in a new line after library and in italic
=> you see author after title on same line with "by" separator

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Marcel de Rooy 2017-08-04 15:07:59 UTC
Fridolin: do not forget to add your name in Assignee field.
Comment 5 Fridolin SOMERS 2017-09-14 14:57:06 UTC
(In reply to Marcel de Rooy from comment #4)
> Fridolin: do not forget to add your name in Assignee field.

Oups forgotten thanks ;)

> Author is displayed into a paragraph making row hight.
Its high whithout t, I mean row is big.
Comment 6 Kyle M Hall 2017-10-27 14:53:19 UTC
Created attachment 68741 [details] [review]
Bug 19022 - inventory location and author display

In inventory result page :
Location is displayed after branch without any difference.
Author is displayed into a paragraph making row hight.

This patch adds for location a span with class like in catalogue detail page, and changes author to be on same line in order to have a more compact display for this table that may be huge.

Test plan :
- Perform inventory with a barcode file
- Look at result
=> you see localtion in a new line after library and in italic
=> you see author after title on same line with "by" separator

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Jonathan Druart 2017-10-27 19:11:16 UTC
Pushed to master for 17.11, thanks to everybody involved!