Bug 19085 - Empty files in English web installer
Summary: Empty files in English web installer
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Whiteboard:
Keywords:
Depends on: 5670
Blocks:
  Show dependency treegraph
 
Reported: 2017-08-11 09:52 UTC by Katrin Fischer
Modified: 2017-10-11 16:54 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19085: Remove empty files patron_attributes.* in installer (1.04 KB, patch)
2017-10-10 12:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 19085: Remove empty files patron_attributes.* in installer (1.16 KB, patch)
2017-10-11 08:34 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 19085: Remove empty files patron_attributes.* in installer (1.25 KB, patch)
2017-10-11 11:52 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2017-08-11 09:52:39 UTC
The English web installer (maybe others too) contains 2 empty files:

- en/mandatory/patron_attributes.sql
- en/mandatory/patron_attributes.txt

It looks like the contents of the files might have been moved into optional.
Comment 1 Jonathan Druart 2017-10-10 12:49:14 UTC
Files added and emptied on bug 5670.
Comment 2 Jonathan Druart 2017-10-10 12:52:00 UTC
Created attachment 67869 [details] [review]
Bug 19085: Remove empty files patron_attributes.* in installer

These files has been added and emptied in the same patch set (bug 5670).
It does not make sense to keep them.
Comment 3 Marc Véron 2017-10-11 08:34:30 UTC
Created attachment 67928 [details] [review]
Bug 19085: Remove empty files patron_attributes.* in installer

These files has been added and emptied in the same patch set (bug 5670).
It does not make sense to keep them.

Signed-off-by: Marc Véron <veron@veron.ch>
Comment 4 Marcel de Rooy 2017-10-11 11:52:12 UTC
Created attachment 67950 [details] [review]
Bug 19085: Remove empty files patron_attributes.* in installer

These files has been added and emptied in the same patch set (bug 5670).
It does not make sense to keep them.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Jonathan Druart 2017-10-11 16:54:07 UTC
Pushed to master for 17.11, thanks to everybody involved!