Bug 19123 - Remove/fix reference to latest release
Summary: Remove/fix reference to latest release
Status: CLOSED FIXED
Alias: None
Product: Project Infrastructure
Classification: Unclassified
Component: Release tools (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-15 23:00 UTC by Katrin Fischer
Modified: 2018-06-04 20:10 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2017-08-15 23:00:28 UTC
The current template of the release notes includes:

http://git.koha-community.org/gitweb/?p=release-tools.git;a=blob;f=templates/release_notes_tmpl.tt;h=1483e521487de2b7f6027fbed0c157a180e04c62;hb=1a8328abed93df17b26a16780ae74344bae59071#l202

The last Koha release was [% lastrelease %], which was released on [% lastreleasedate %].
[% END %]

This has never appeared to work correctly for me, but maybe I am not understanding how this should work. I think maybe it should show:

- the last release of the branch the release notes are for
- the last release of latest release (to maybe show the user that he is running an old version?)

But it appears to do neither.
Comment 1 Jonathan Druart 2017-10-30 19:55:18 UTC
17.05.05 and 16.11.13 seems ok:
https://koha-community.org/koha-17-05-05-release/
 "The last Koha release was 17.05.04, which was released on sept. 20, 2017."
https://koha-community.org/koha-16-11-13-release/
 "The last Koha release was 16.11.12, which was released on September 21, 2017."

But not 16.05.18
https://koha-community.org/koha-16-05-18-release/
 "The last Koha release was 3.22.8, which was released on June 24, 2016."

I guess you (RMaint) are updating it manually?
Comment 2 Jonathan Druart 2017-10-30 19:55:51 UTC
Ok so apparently it reads the docs/history.txt to generate it.

What's the point of this info? Should we remove it or fix it?
Comment 3 Katrin Fischer 2017-11-01 11:11:29 UTC
I fixed it manually every time, it never generated right for me.

I don't think it adds valuable information. The easiest fix would be to remove it.
Comment 4 Jonathan Druart 2017-11-01 16:20:45 UTC
commit 6fb40783995ef1171ef784f79e6d077b0ae60aec
  Bug 19123: Remove reference to the last release