Bug 19212 - Warns when asking for a discharge OPAC
Summary: Warns when asking for a discharge OPAC
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-30 23:35 UTC by Aleisha Amohia
Modified: 2017-10-27 19:11 UTC (History)
2 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19212: Preventing warns when asking for discharge (933 bytes, patch)
2017-08-30 23:36 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 19212: Preventing warns when asking for discharge (1.11 KB, patch)
2017-09-12 13:01 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 19212: Preventing warns when asking for discharge (1.11 KB, patch)
2017-10-27 14:42 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2017-08-30 23:35:46 UTC
To reproduce:
1) Ensure the useDischarge syspref is enabled
2) Log in to OPAC
3) Go to 'ask for a discharge'
4) Notice warns:

Use of uninitialized value $op in string eq at /home/vagrant/kohaclone/opac/opac-discharge.pl line 50.
Use of uninitialized value $op in string eq at /home/vagrant/kohaclone/opac/opac-discharge.pl line 62.
Comment 1 Aleisha Amohia 2017-08-30 23:36:51 UTC
Created attachment 66660 [details] [review]
Bug 19212: Preventing warns when asking for discharge

To test:
1) Ensure the useDischarge syspref is enabled
2) Log in to OPAC
3) Go to 'ask for a discharge'
4) Notice warns
5) Apply patch and refresh page
6) Notice warns are gone

Sponsored-by: Catalyst IT
Comment 2 Claire Gravely 2017-09-12 08:21:52 UTC
Hi Aleisha,

I was unable to replicate the warns. When asking for a discharge I am just told it will be avealable in a few days without any errors.
Comment 3 Marc Véron 2017-09-12 12:59:46 UTC
(In reply to Claire Gravely from comment #2)
> Hi Aleisha,
> 
> I was unable to replicate the warns. When asking for a discharge I am just
> told it will be avealable in a few days without any errors.

I can confirm the warnings (in plack-error.log)
Comment 4 Marc Véron 2017-09-12 13:01:54 UTC
Created attachment 67081 [details] [review]
Bug 19212: Preventing warns when asking for discharge

To test:
1) Ensure the useDischarge syspref is enabled
2) Log in to OPAC
3) Go to 'ask for a discharge'
4) Notice warns
5) Apply patch and refresh page
6) Notice warns are gone

Sponsored-by: Catalyst IT

Warnings reproduced in plack-error.log, with patch they are gone.
Signed-off-by: Marc Véron <veron@veron.ch>
Comment 5 Kyle M Hall 2017-10-27 14:42:40 UTC
Created attachment 68727 [details] [review]
Bug 19212: Preventing warns when asking for discharge

To test:
1) Ensure the useDischarge syspref is enabled
2) Log in to OPAC
3) Go to 'ask for a discharge'
4) Notice warns
5) Apply patch and refresh page
6) Notice warns are gone

Sponsored-by: Catalyst IT

Warnings reproduced in plack-error.log, with patch they are gone.
Signed-off-by: Marc Véron <veron@veron.ch>
Comment 6 Jonathan Druart 2017-10-27 19:11:33 UTC
Pushed to master for 17.11, thanks to everybody involved!