Bug 19348 - Title column in item search is too narrow
Summary: Title column in item search is too narrow
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Nick Clemens
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-20 12:15 UTC by Katrin Fischer
Modified: 2017-11-10 06:49 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19348: Title column in item search is too narrow (3.43 KB, patch)
2017-09-20 13:31 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 19348: Title column in item search is too narrow (3.43 KB, patch)
2017-09-22 19:17 UTC, Dominic Pichette
Details | Diff | Splinter Review
Bug 19348: Title column in item search is too narrow (3.48 KB, patch)
2017-09-22 19:29 UTC, Dominic Pichette
Details | Diff | Splinter Review
Bug 19348: Title column in item search is too narrow (3.54 KB, patch)
2017-10-18 19:27 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2017-09-20 12:15:32 UTC
When using the item search the title column is often too narrow to comfortably read the titles. This is because the colum width seems to be calculated dynamically and often the titles consists of a lot of 'small' words can be easily put on multiple lines. 

It would be nice if there was a min-width for this column for improved usability.
Comment 1 Owen Leonard 2017-09-20 13:31:34 UTC
Created attachment 67234 [details] [review]
Bug 19348: Title column in item search is too narrow

This patch adds IDs to the item search results table header so that
columns can be targeted by CSS or JS. The CSS for the item search page
has been modified to give the title column a minimum width.

To test, apply the patch and clear your browser cache if necessary.
Perform an item search and confirm that the title column stays at a
reasonable width.
Comment 2 Dominic Pichette 2017-09-22 19:17:43 UTC
Created attachment 67333 [details] [review]
Bug 19348: Title column in item search is too narrow

This patch adds IDs to the item search results table header so that
columns can be targeted by CSS or JS. The CSS for the item search page
has been modified to give the title column a minimum width.

To test, apply the patch and clear your browser cache if necessary.
Perform an item search and confirm that the title column stays at a
reasonable width.
Comment 3 Dominic Pichette 2017-09-22 19:29:49 UTC
Created attachment 67334 [details] [review]
Bug 19348: Title column in item search is too narrow

This patch adds IDs to the item search results table header so that
columns can be targeted by CSS or JS. The CSS for the item search page
has been modified to give the title column a minimum width.

To test, apply the patch and clear your browser cache if necessary.
Perform an item search and confirm that the title column stays at a
reasonable width.

Signed-off-by: Dominic Pichette <dominic@inlibro.com>
Comment 4 Nick Clemens 2017-10-18 19:27:48 UTC
Created attachment 68278 [details] [review]
Bug 19348: Title column in item search is too narrow

This patch adds IDs to the item search results table header so that
columns can be targeted by CSS or JS. The CSS for the item search page
has been modified to give the title column a minimum width.

To test, apply the patch and clear your browser cache if necessary.
Perform an item search and confirm that the title column stays at a
reasonable width.

Signed-off-by: Dominic Pichette <dominic@inlibro.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Jonathan Druart 2017-10-20 20:16:31 UTC
Pushed to master for 17.11, thanks to everybody involved!
Comment 6 Katrin Fischer 2017-11-10 06:49:11 UTC
This might be interesting for backporting (almost a bug).