Bug 19413 - Move the location of the Ok and cancel buttons to the 008 cataloguing builder
Summary: Move the location of the Ok and cancel buttons to the 008 cataloguing builder
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Alex Buckley
QA Contact: Marcel de Rooy
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-05 02:02 UTC by Alex Buckley
Modified: 2017-10-13 17:01 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19413 - Moving the OK and Cancel inputs to the top of the 008 builder (2.56 KB, patch)
2017-10-05 02:20 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 19413 - Moving the OK and Cancel inputs to the top of the 008 builder (2.25 KB, patch)
2017-10-05 04:23 UTC, Dilan Johnpullé
Details | Diff | Splinter Review
Bug 19413 - Followup Changed fieldset id value (1.90 KB, patch)
2017-10-11 21:45 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 19413 - Followup Changed fieldset id value (2.09 KB, patch)
2017-10-12 00:05 UTC, Dilan Johnpullé
Details | Diff | Splinter Review
Bug 19413 - Moving the OK and Cancel inputs to the top of the 008 builder (2.35 KB, patch)
2017-10-13 08:55 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 19413 - Followup Changed fieldset id value (2.18 KB, patch)
2017-10-13 08:55 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Buckley 2017-10-05 02:02:28 UTC
The inputs that librarians are most likely to interact with on the Cataloguing 008 Builder are types of materials, and dates which are all at the top of the window.

The patch attached to this bug report will place the OK and cancel inputs at the top of the page therefore improving the UX of the page because they don't have to scroll past a whole lot of unnecessary inputs
Comment 1 Alex Buckley 2017-10-05 02:20:55 UTC
Created attachment 67623 [details] [review]
Bug 19413 - Moving the OK and Cancel inputs to the top of the 008 builder

Test plan:
1. Go into the Cataloguing module in the staff intranet
2. Create a new record in one of your MARC frameworks
3. Click on the small tag editor icon to the right
of the 008 field
4. A new window (containing the 008 builder)
will appear and notice that the OK and cancel buttons
are at the bottom of the page in this window
5. Apply patch
6. Refresh this window (right click and select refresh
button)
7. Notice that the OK and cancel buttons have moved
to the top right of the page

Sponsored-By: Catalyst IT
Comment 2 Dilan Johnpullé 2017-10-05 04:23:20 UTC
Created attachment 67626 [details] [review]
Bug 19413 - Moving the OK and Cancel inputs to the top of the 008 builder

Followed test plan and patch applies and functions as described
Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Comment 3 Marcel de Rooy 2017-10-06 09:59:55 UTC
I see that git grep "id=\"action\"" returns various results.
Please explain why your change in staff-global would not have various side effects?
Comment 4 Alex Buckley 2017-10-11 21:45:59 UTC
Created attachment 67979 [details] [review]
Bug 19413 - Followup Changed fieldset id value

Sponsored-By: Catalyst IT
Comment 5 Alex Buckley 2017-10-11 21:47:27 UTC
Hi Marcel 

Apologies I made a mistake in not making the id value more specific. I have made the id value "fixedlengthbuilderaction" in the followup patch I have just attached to this bug report. Please test again
Comment 6 Dilan Johnpullé 2017-10-12 00:05:20 UTC
Created attachment 67984 [details] [review]
Bug 19413 - Followup Changed fieldset id value

Followed test plan again and patch still applies and works as expected.

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Comment 7 Marcel de Rooy 2017-10-13 08:55:46 UTC
Created attachment 68053 [details] [review]
Bug 19413 - Moving the OK and Cancel inputs to the top of the 008 builder

Followed test plan and patch applies and functions as described
Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 8 Marcel de Rooy 2017-10-13 08:55:51 UTC
Created attachment 68054 [details] [review]
Bug 19413 - Followup Changed fieldset id value

Followed test plan again and patch still applies and works as expected.

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 9 Marcel de Rooy 2017-10-13 08:59:42 UTC
(In reply to Alex Buckley from comment #5)
> Hi Marcel 
> 
> Apologies I made a mistake in not making the id value more specific. I have
> made the id value "fixedlengthbuilderaction" in the followup patch I have
> just attached to this bug report. Please test again

Thx. Cool name ;)

QA Comment:
As mentioned in first comment, this will help librarians only adjusting information at the top of the form. Sounds reasonable.
On the other hand those librarians that need to adjust something too at the end will now complain :) Would be interesting to make it floating like the cataloguing editor itself? No blocker for me. Especially since hitting Enter here submits the form too..
Comment 10 Jonathan Druart 2017-10-13 17:01:07 UTC
Pushed to master for 17.11, thanks to everybody involved!