Bug 19531 - When editing patrons without circulation permission redirect should be to the patron's detail page
Summary: When editing patrons without circulation permission redirect should be to the...
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-25 20:07 UTC by Katrin Fischer
Modified: 2017-10-27 17:18 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19531: When saving patron record do not redirect to circ if not authorised (1.98 KB, patch)
2017-10-25 20:31 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 19531: When saving patron record do not redirect to circ if not authorised (2.03 KB, patch)
2017-10-25 20:50 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 19531: When saving patron record do not redirect to circ if not authorised (2.08 KB, patch)
2017-10-26 16:05 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2017-10-25 20:07:38 UTC
This was just reported for 16.11.10, but was able to confirm in master:

1) create a staff account with catalog and borrowers permission
2) create a new user with this patron account
3) try to edit the patron account - you get a log in screen (Error: You do not have permission to access this page.)
Comment 1 Jonathan Druart 2017-10-25 20:31:18 UTC
Created attachment 68557 [details] [review]
Bug 19531: When saving patron record do not redirect to circ if not authorised

If the logged in patron does not have the necessary permission we should
not redirect to circulation.pl but moremember.pl instead

Test plan:
With the borrowers permission, you should be able to edit a patron and
be redirect to the moremember page
Comment 2 Katrin Fischer 2017-10-25 20:50:10 UTC
Created attachment 68568 [details] [review]
Bug 19531: When saving patron record do not redirect to circ if not authorised

If the logged in patron does not have the necessary permission we should
not redirect to circulation.pl but moremember.pl instead

Test plan:
With the borrowers permission, you should be able to edit a patron and
be redirect to the moremember page

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Nick Clemens 2017-10-26 16:05:06 UTC
Created attachment 68631 [details] [review]
Bug 19531: When saving patron record do not redirect to circ if not authorised

If the logged in patron does not have the necessary permission we should
not redirect to circulation.pl but moremember.pl instead

Test plan:
With the borrowers permission, you should be able to edit a patron and
be redirect to the moremember page

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Jonathan Druart 2017-10-27 17:18:12 UTC
Pushed to master for 17.11, thanks to everybody involved!