Bug 19674 - Broken indicators of changed fields in manage staged MARC records template
Summary: Broken indicators of changed fields in manage staged MARC records template
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Whiteboard:
Keywords:
Depends on: 16538
Blocks:
  Show dependency treegraph
 
Reported: 2017-11-21 16:15 UTC by Owen Leonard
Modified: 2017-12-07 14:25 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19674: Broken indicators of changed fields in manage staged MARC records template (1.42 KB, patch)
2017-11-21 16:21 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 19674: Broken indicators of changed fields in manage staged MARC records template (1.48 KB, patch)
2017-11-22 08:52 UTC, Claire Gravely
Details | Diff | Splinter Review
Bug 19674: Broken indicators of changed fields in manage staged MARC records template (1.57 KB, patch)
2017-11-27 13:20 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2017-11-21 16:15:38 UTC
May patch for Bug 16538 removed some CSS which should have stayed. Without it, the manage staged MARC records page always says that all matching options have been modified.
Comment 1 Owen Leonard 2017-11-21 16:21:13 UTC Comment hidden (obsolete)
Comment 2 Claire Gravely 2017-11-22 08:52:40 UTC
Created attachment 69269 [details] [review]
Bug 19674: Broken indicators of changed fields in manage staged MARC records template

This patch returns some CSS to the manage staged MARC records template
which was incorrectly removed by Gug 16538.

To test, apply the patch and go to Tools -> Staged MARC management.
Choose a staged MARC file.

Changing any of the <select> fields in the first section should cause a
label to appear showing that the selection has changed, along with a
link to reset the option to its original state. Clicking 'Reset' should
make the label and the link disappear.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Comment 3 Marcel de Rooy 2017-11-27 13:20:59 UTC
Created attachment 69378 [details] [review]
Bug 19674: Broken indicators of changed fields in manage staged MARC records template

This patch returns some CSS to the manage staged MARC records template
which was incorrectly removed by Gug 16538.

To test, apply the patch and go to Tools -> Staged MARC management.
Choose a staged MARC file.

Changing any of the <select> fields in the first section should cause a
label to appear showing that the selection has changed, along with a
link to reset the option to its original state. Clicking 'Reset' should
make the label and the link disappear.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Jonathan Druart 2017-12-07 14:25:17 UTC
Pushed to master for 18.05, thanks to everybody involved!