Bug 19692 - Unclosed div in opac-shelves.tt
Summary: Unclosed div in opac-shelves.tt
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Simon Pouchol
QA Contact: Marcel de Rooy
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-24 15:51 UTC by Victor Grousset/tuxayo
Modified: 2017-12-08 13:26 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19692 : fix unclosed div in opac-shelves.tt (1.49 KB, patch)
2017-11-24 16:02 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review
Bug 19692 : fix unclosed div in opac-shelves.tt (1.55 KB, patch)
2017-11-24 19:19 UTC, Dominic Pichette
Details | Diff | Splinter Review
Bug 19692 : fix unclosed div in opac-shelves.tt (1.64 KB, patch)
2017-11-27 13:04 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 19692 : fix unclosed div in opac-shelves.tt (1.60 KB, patch)
2017-11-27 13:27 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Grousset/tuxayo 2017-11-24 15:51:55 UTC
It was found when customizing an instance.

The comment makes it clear that it should be a closing tag.

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt;hb=570eb4026642f71e462c7746a9c91721aa9334c1#l725
Comment 1 Victor Grousset/tuxayo 2017-11-24 16:02:58 UTC
Created attachment 69336 [details] [review]
Bug 19692 : fix unclosed div in opac-shelves.tt

Test plan:
1. set syspref OpacKohaUrl to "Show"
2. Log into the OPAC
3. /cgi-bin/koha/opac-shelves.pl
4. Notice that "Powered by Koha" is not in the footer in this page.
  When on the other tabs it's in the footer (out of .main)
5. Apply this patch
6. Notice that "Powered by Koha" now in the footer in the "your lists" page
Comment 2 Dominic Pichette 2017-11-24 19:19:56 UTC
Created attachment 69337 [details] [review]
Bug 19692 : fix unclosed div in opac-shelves.tt

Test plan:
1. set syspref OpacKohaUrl to "Show"
2. Log into the OPAC
3. /cgi-bin/koha/opac-shelves.pl
4. Notice that "Powered by Koha" is not in the footer in this page.
  When on the other tabs it's in the footer (out of .main)
5. Apply this patch
6. Notice that "Powered by Koha" now in the footer in the "your lists" page

Signed-off-by: Dominic Pichette <dominic@inlibro.com>
Comment 3 Marcel de Rooy 2017-11-27 13:04:36 UTC
Created attachment 69376 [details] [review]
Bug 19692 : fix unclosed div in opac-shelves.tt

Test plan:
1. set syspref OpacKohaUrl to "Show"
2. Log into the OPAC
3. /cgi-bin/koha/opac-shelves.pl
4. Notice that "Powered by Koha" is not in the footer in this page.
  When on the other tabs it's in the footer (out of .main)
5. Apply this patch
6. Notice that "Powered by Koha" now in the footer in the "your lists" page

Signed-off-by: Dominic Pichette <dominic@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Victor Grousset/tuxayo 2017-11-27 13:27:32 UTC
Created attachment 69379 [details] [review]
Bug 19692 : fix unclosed div in opac-shelves.tt

Test plan:
1. set syspref OpacKohaUrl to "Show"
2. Log into the OPAC
3. /cgi-bin/koha/opac-shelves.pl
4. Notice that "Powered by Koha" is not in the footer in this page.
  When on the other tabs it's in the footer (out of .main)
5. Apply this patch
6. Notice that "Powered by Koha" now in the footer in the "your lists" page

Signed-off-by: Dominic Pichette <dominic@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Victor Grousset/tuxayo 2017-11-27 13:29:17 UTC
I've changed the author of the commit to Simon Pouchol (the work was on my machine).
That might be their first contribution to the codebase, that's why it might matters :)
Comment 6 Jonathan Druart 2017-12-07 12:38:54 UTC
Patch has been pushed to master for 18.05.
Congratulations Simon for your first patch in!
Comment 7 Victor Grousset/tuxayo 2017-12-08 13:26:46 UTC
Hooray :D