Bug 19726 - Move admin templates JavaScript to the footer: Preferences
Summary: Move admin templates JavaScript to the footer: Preferences
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Josef Moravec
URL:
Keywords:
Depends on:
Blocks: 17858 14576
  Show dependency treegraph
 
Reported: 2017-12-01 14:14 UTC by Owen Leonard
Modified: 2018-12-03 20:04 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 19726 - Move admin templates JavaScript to the footer: Preferences (13.34 KB, patch)
2017-12-01 14:35 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 19726 - Move admin templates JavaScript to the footer: Preferences (13.40 KB, patch)
2017-12-05 11:14 UTC, Claire Gravely
Details | Diff | Splinter Review
Bug 19726 - Move admin templates JavaScript to the footer: Preferences (13.45 KB, patch)
2017-12-07 09:40 UTC, Josef Moravec
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2017-12-01 14:14:22 UTC
In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header.

This patch will do so for system preferences, both standard and local.
Comment 1 Owen Leonard 2017-12-01 14:35:40 UTC Comment hidden (obsolete)
Comment 2 Claire Gravely 2017-12-05 11:14:39 UTC
Created attachment 69500 [details] [review]
Bug 19726 - Move admin templates JavaScript to the footer: Preferences

This patch modifies the staff client's system preferences templates so
that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
both the standard and local use system preferences:

 - WYSIWYG editor
 - Confirmation messages
 - Table sorting
 - Multiple selects (CoceProviders for example)

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Comment 3 Josef Moravec 2017-12-07 09:40:16 UTC
Created attachment 69601 [details] [review]
Bug 19726 - Move admin templates JavaScript to the footer: Preferences

This patch modifies the staff client's system preferences templates so
that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
both the standard and local use system preferences:

 - WYSIWYG editor
 - Confirmation messages
 - Table sorting
 - Multiple selects (CoceProviders for example)

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 4 Jonathan Druart 2017-12-11 14:37:46 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 5 Nick Clemens 2017-12-14 18:00:33 UTC
Awesome work all! Skipping for 17.11, enhancement.