In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for offline circulation templates.
Created attachment 69483 [details] [review] Bug 19744: Move template JavaScript to the footer: Offline circulation This patch modifies the staff client offline circulation templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. Circulation -> Built-in offline circulation interface -> Synchronize -> Download records -> Check out -> Check in -> Synchronize -> Upload transactions -> Pending offline circulations -> Check all, uncheck all -> Delete -> Process Circulation -> Upload offline circulation data -> Upload .koc file (gerated by the Koha Offline Circulation program, for instance).
Created attachment 69794 [details] [review] Bug 19744: Move template JavaScript to the footer: Offline circulation This patch modifies the staff client offline circulation templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. Circulation -> Built-in offline circulation interface -> Synchronize -> Download records -> Check out -> Check in -> Synchronize -> Upload transactions -> Pending offline circulations -> Check all, uncheck all -> Delete -> Process Circulation -> Upload offline circulation data -> Upload .koc file (gerated by the Koha Offline Circulation program, for instance). Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com>
Created attachment 70068 [details] [review] Bug 19744: Move template JavaScript to the footer: Offline circulation This patch modifies the staff client offline circulation templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. Circulation -> Built-in offline circulation interface -> Synchronize -> Download records -> Check out -> Check in -> Synchronize -> Upload transactions -> Pending offline circulations -> Check all, uncheck all -> Delete -> Process Circulation -> Upload offline circulation data -> Upload .koc file (gerated by the Koha Offline Circulation program, for instance). Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Pushed to master for 18.05, thanks to everybody involved!
Enhancement, skipping for 17.11.x. Awesome work everybody!