Bug 19906 - Move template JavaScript to the footer: NORMARC editor plugins
Summary: Move template JavaScript to the footer: NORMARC editor plugins
Status: RESOLVED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 17858
  Show dependency treegraph
 
Reported: 2018-01-02 19:19 UTC by Owen Leonard
Modified: 2018-02-28 13:57 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19906: Move template JavaScript to the footer: NORMARC editor plugins (686.90 KB, patch)
2018-01-02 19:58 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-01-02 19:19:33 UTC
NORMARC plugin templates already have JavaScript at the bottom of the template instead of the top, but they should still be modified to be consistent with other templates which have been updated as part of Bug 17858.
Comment 1 Owen Leonard 2018-01-02 19:58:21 UTC
Created attachment 70234 [details] [review]
Bug 19906: Move template JavaScript to the footer: NORMARC editor plugins

This patch updates NORMARC plugin templates so that JavaScript is
included in the footer following the same pattern as other
templates which have been modified to fix Bug 17858.

To test you do not need a NORMARC system.

Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.

From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.

- normarc_field_007.tt
- normarc_field_008.tt
- normarc_leader.tt
Comment 2 Magnus Enger 2018-02-28 13:57:22 UTC
NORMARC is going away this year, no need to spend time on this. See Bug 18984.