Bug 20139 - Improve MARC mapping translatable strings
Summary: Improve MARC mapping translatable strings
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: paxed
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-06 05:41 UTC by paxed
Modified: 2018-04-06 16:14 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 20139: Improve MARC mapping translatable strings (2.76 KB, patch)
2018-02-06 05:42 UTC, paxed
Details | Diff | Splinter Review
Bug 20139: Improve MARC mapping translatable strings (2.85 KB, patch)
2018-02-27 16:57 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2018-02-06 05:41:04 UTC
There's one untranslatable error message, and couple other messages that are annoying to translate due to using concatenation.
Comment 1 paxed 2018-02-06 05:42:51 UTC
Created attachment 71241 [details] [review]
Bug 20139: Improve MARC mapping translatable strings

- Allow translating one error message
- Use string formatting with placeholders instead of concatenation

Test plan:

1) Go to Home -> Administration -> Koha to MARC Mapping
2) Click on the "Add" button to add a new mapping
3) Note the popup text looks correct
4) Enter something invalid
5) Note the error message
6) Click on any of the "Remove" buttons to remove a mapping
7) Note the popup text looks correct
8) Update, translate the new msgid's, and install a language
9) Repeat 1-7, note how the message are in the correct
   language
Comment 2 Jonathan Druart 2018-02-27 16:57:32 UTC
Created attachment 72276 [details] [review]
Bug 20139: Improve MARC mapping translatable strings

- Allow translating one error message
- Use string formatting with placeholders instead of concatenation

Test plan:

1) Go to Home -> Administration -> Koha to MARC Mapping
2) Click on the "Add" button to add a new mapping
3) Note the popup text looks correct
4) Enter something invalid
5) Note the error message
6) Click on any of the "Remove" buttons to remove a mapping
7) Note the popup text looks correct
8) Update, translate the new msgid's, and install a language
9) Repeat 1-7, note how the message are in the correct
   language

Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Jonathan Druart 2018-02-27 16:57:53 UTC
Trivial, skipping QA.
Comment 4 Jonathan Druart 2018-02-27 18:59:26 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 5 Nick Clemens 2018-04-06 16:14:41 UTC
Does not apply for 17.11.X - rebase if needed