Floody logs distracts from debugging real problems. This will clean up warnings triggered in admin/aqplan.pl
20185 cleans up some of them while addressing perl -wc issues. This cleans up more.
Created attachment 71639 [details] [review] Bug 20201: Silence warnings triggered by admin/aqplan.pl TEST PLAN --------- 0) back up DB 1) Run the following commands on a kohadevbox: reset_all git bz apply 20185 echo | sudo tee /var/log/koha/kohadev/plack-error.log restart_all 2) Navigate in a staff client: Home -> Administration -> Budgets -> Edit -> Planning by libraries -- could be any of the planning, but by libraries is nicely visible on screen. 3) Run the following commands: cat /var/log/koha/kohadev/plack-error.log -- several warnings. 4) Run the following commands: git bz apply 20201 echo | sudo tee /var/log/koha/kohadev/plack-error.log restart_all 5) repeat step 2 and refresh the staff client page. -- this time warnings related to aqplan.pl are not there. 6) run koha qa test tools
Created attachment 72269 [details] [review] Bug 20201: Silence warnings triggered by admin/aqplan.pl TEST PLAN --------- 0) back up DB 1) Run the following commands on a kohadevbox: reset_all git bz apply 20185 echo | sudo tee /var/log/koha/kohadev/plack-error.log restart_all 2) Navigate in a staff client: Home -> Administration -> Budgets -> Edit -> Planning by libraries -- could be any of the planning, but by libraries is nicely visible on screen. 3) Run the following commands: cat /var/log/koha/kohadev/plack-error.log -- several warnings. 4) Run the following commands: git bz apply 20201 echo | sudo tee /var/log/koha/kohadev/plack-error.log restart_all 5) repeat step 2 and refresh the staff client page. -- this time warnings related to aqplan.pl are not there. 6) run koha qa test tools Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Trivial, skipping QA.
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all! Pushed to stable for 17.11.04
Comment on attachment 72269 [details] [review] Bug 20201: Silence warnings triggered by admin/aqplan.pl Review of attachment 72269 [details] [review]: ----------------------------------------------------------------- ::: admin/aqplan.pl @@ +106,4 @@ > $authcat = 'Asort1' if not defined $authcat; # defaults to Asort if no authcat given > > my $budget_id = $input->param('budget_id'); > +my $op = $input->param("op") // q{}; This line actually hides a bug introduced by Bug 16754.