Bug 20204 - FrameworkPlugin.t should not depend on CPL branch
Summary: FrameworkPlugin.t should not depend on CPL branch
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Target Milestone: ---
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-15 08:17 UTC by Marcel de Rooy
Modified: 2018-06-04 20:15 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 20204: Add TestBuilder to replace CPL branch (2.48 KB, patch)
2018-02-15 08:25 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2018-02-15 08:17:36 UTC
Triggered by:
<Joubu> could you take a look at the noise of t/db_dependent/FrameworkPlugin.t?

I took a look.
And saw something else :)
If you dont have CPL, the test crashes.

Note that the noise is not from the test, but from poorly written plugins. Especially the unimarc plugins generate much uninitialized value and substr outside of string warnings. We should not have added Modern::Perl in one pass imo, but consider them one by one.. See bug 19996.
I have been working on those plugins, but stranded so far on lack of support.
Comment 1 Marcel de Rooy 2018-02-15 08:25:36 UTC
Created attachment 71640 [details] [review]
Bug 20204: Add TestBuilder to replace CPL branch

Remove CPL; without this branch, the test crashes.
Rearrange modules at the start.
Add Koha::Database calls.
Move a few global my vars to our level.
Remove intermediate rollbacks.

Test plan:
[1] Run prove t/db_dependent/FrameworkPlugin.t
    Ignore noise from unimarc plugins :)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2018-02-15 08:27:33 UTC
Signing off myself: trivial edits.
Comment 3 Jonathan Druart 2018-02-15 14:25:23 UTC
Patch pushed to master for 18.05

Thanks Marcel