Bug 20239 - Fix spelling on authority linker plugin
Summary: Fix spelling on authority linker plugin
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Whiteboard:
Keywords: Academy
Depends on: 19949
Blocks:
  Show dependency treegraph
 
Reported: 2018-02-18 13:13 UTC by Katrin Fischer
Modified: 2018-02-26 14:19 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 20239: Fix spelling on authority linker plugin (2.90 KB, patch)
2018-02-21 18:08 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20239: Fix spelling on authority linker plugin (2.94 KB, patch)
2018-02-23 08:40 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 20239: Fix spelling on authority linker plugin (3.09 KB, patch)
2018-02-23 10:57 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2018-02-18 13:13:34 UTC
When using the autority linker plugin, 'choose' would look better as 'Choose'.

To test:
- create a new record
- go to 100
- click on plugin link behind $a
- look for an existing authoriy in your system
- take a look at the results table for your search

	0 times 	choose 	Edit authority

_C_hoose would be nicer, wouldn't it?
Comment 1 Owen Leonard 2018-02-21 18:08:35 UTC
Created attachment 72050 [details] [review]
Bug 20239: Fix spelling on authority linker plugin

This patch corrects the capitalization of the "Choose" link in the
pop-up window for selecting an authority record to link to a MARC field.

This patch also converts the link, and the "Edit authority" link, to
Bootstrap buttons.

To test:
- Create a new record
- Go to the 100 field
- Click on plugin link behind $a
- Look for an existing authoriy in your system
- In the table of search results, confirm that the "Choose" and "Edit
  authority" links look correct and work correctly.
Comment 2 Katrin Fischer 2018-02-23 08:40:00 UTC
Created attachment 72102 [details] [review]
Bug 20239: Fix spelling on authority linker plugin

This patch corrects the capitalization of the "Choose" link in the
pop-up window for selecting an authority record to link to a MARC field.

This patch also converts the link, and the "Edit authority" link, to
Bootstrap buttons.

To test:
- Create a new record
- Go to the 100 field
- Click on plugin link behind $a
- Look for an existing authoriy in your system
- In the table of search results, confirm that the "Choose" and "Edit
  authority" links look correct and work correctly.
Comment 3 Marcel de Rooy 2018-02-23 10:57:24 UTC
Created attachment 72111 [details] [review]
Bug 20239: Fix spelling on authority linker plugin

This patch corrects the capitalization of the "Choose" link in the
pop-up window for selecting an authority record to link to a MARC field.

This patch also converts the link, and the "Edit authority" link, to
Bootstrap buttons.

To test:
- Create a new record
- Go to the 100 field
- Click on plugin link behind $a
- Look for an existing authoriy in your system
- In the table of search results, confirm that the "Choose" and "Edit
  authority" links look correct and work correctly.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2018-02-23 10:57:51 UTC
(In reply to Katrin Fischer from comment #2)
QAM: You forgot your signoff line ;)
Comment 5 Katrin Fischer 2018-02-23 17:00:03 UTC
(In reply to Marcel de Rooy from comment #4)
> (In reply to Katrin Fischer from comment #2)
> QAM: You forgot your signoff line ;)

Indeed - thx, Marcel!
Comment 6 Jonathan Druart 2018-02-26 14:19:00 UTC
Pushed to master for 18.05, thanks to everybody involved!