Bug 20276 - GetCourseItem is using the wrong call to get itemnumber
Summary: GetCourseItem is using the wrong call to get itemnumber
Status: Pushed to Stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Course reserves (show other bugs)
Version: 17.05
Hardware: All All
: P5 - low major (vote)
Assignee: Fridolin SOMERS
QA Contact: Josef Moravec
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-22 19:01 UTC by Nick Clemens
Modified: 2018-02-26 12:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 20276: Fix GetCourseItem call to get itemnumber (1.47 KB, patch)
2018-02-23 10:50 UTC, Fridolin SOMERS
Details | Diff | Splinter Review
Bug 20276: Fix GetCourseItem call to get itemnumber (1.53 KB, patch)
2018-02-23 11:24 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 20276: Fix GetCourseItem call to get itemnumber (1.58 KB, patch)
2018-02-25 10:25 UTC, Josef Moravec
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2018-02-22 19:01:45 UTC
In course_reserves/add_items.pl we now get the item via Objects

This line:
 66     my $course_item = GetCourseItem( itemnumber => $item->{'itemnumber'} );
Should be:
 66     my $course_item = GetCourseItem( itemnumber => $item->itemnumber );
Comment 1 Fridolin SOMERS 2018-02-23 10:36:35 UTC
Ah corrected since 17.11 by :

Bug 18276: Remove GetBiblioFromItemNumber - Course reserves
Comment 2 Fridolin SOMERS 2018-02-23 10:50:07 UTC
Created attachment 72110 [details] [review]
Bug 20276: Fix GetCourseItem call to get itemnumber

In 17.05.x :
In course_reserves/add_items.pl we now get the item via Objects.
This line:
 66     my $course_item = GetCourseItem( itemnumber => $item->{'itemnumber'} );
Should be:
 66     my $course_item = GetCourseItem( itemnumber => $item->itemnumber );

This is corrected since 17.11 by :
Bug 18276: Remove GetBiblioFromItemNumber - Course reserves

Test plan :
1) Create a course reserve and add items.
2) Correct information must be displayed on the detail page of the course
reserve, on staff and OPAC interface.
3) Try to add a non existing barcode, you get the page with a message
Comment 3 Nick Clemens 2018-02-23 11:24:43 UTC
Created attachment 72113 [details] [review]
Bug 20276: Fix GetCourseItem call to get itemnumber

In 17.05.x :
In course_reserves/add_items.pl we now get the item via Objects.
This line:
 66     my $course_item = GetCourseItem( itemnumber => $item->{'itemnumber'} );
Should be:
 66     my $course_item = GetCourseItem( itemnumber => $item->itemnumber );

This is corrected since 17.11 by :
Bug 18276: Remove GetBiblioFromItemNumber - Course reserves

Test plan :
1) Create a course reserve and add items.
2) Correct information must be displayed on the detail page of the course
reserve, on staff and OPAC interface.
3) Try to add a non existing barcode, you get the page with a message

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Josef Moravec 2018-02-25 10:25:08 UTC
Created attachment 72186 [details] [review]
Bug 20276: Fix GetCourseItem call to get itemnumber

In 17.05.x :
In course_reserves/add_items.pl we now get the item via Objects.
This line:
 66     my $course_item = GetCourseItem( itemnumber => $item->{'itemnumber'} );
Should be:
 66     my $course_item = GetCourseItem( itemnumber => $item->itemnumber );

This is corrected since 17.11 by :
Bug 18276: Remove GetBiblioFromItemNumber - Course reserves

Test plan :
1) Create a course reserve and add items.
2) Correct information must be displayed on the detail page of the course
reserve, on staff and OPAC interface.
3) Try to add a non existing barcode, you get the page with a message

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 5 Fridolin SOMERS 2018-02-26 12:42:07 UTC
Pushed to 17.05.x, will be in v17.05.10