Bug 20301 - Allow translating "View" in manage MARC import
Summary: Allow translating "View" in manage MARC import
Status: Pushed to Stable
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: paxed
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-27 09:31 UTC by paxed
Modified: 2018-04-06 17:47 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 20301: Allow translating "View" in manage MARC import (2.22 KB, patch)
2018-02-27 09:33 UTC, paxed
Details | Diff | Splinter Review
Bug 20301: Allow translating "View" in manage MARC import (2.29 KB, patch)
2018-02-27 16:58 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2018-02-27 09:31:46 UTC
When looking at the table showing the staged MARC records, the "View" text in the Diff-column is not translatable.
Comment 1 paxed 2018-02-27 09:33:39 UTC
Created attachment 72251 [details] [review]
Bug 20301: Allow translating "View" in manage MARC import

When looking at the table showing the staged MARC records, the "View"
text in the Diff-column is not translatable. Make it so.

Test plan:

1) Go to Home -> Tools -> Stage MARC records for import
2) Select eg. t/db_dependent/www/data/marc21record.mrc and upload the file
3) Click on Stage for import
   -> Manage staged records
   -> Import this batch into the catalog
4) Wait for zebra to reindex, or trigger it yourself by
   running rebuild_zebra.pl -a -b -r
5) Go to Home -> Tools -> Stage MARC records for import
6) Select the same file as in part 2 and upload the file
7) Change the Record matching rule to ISBN (020$a)
8) Click on Stage for import
   -> Manage staged records
9) In the table below, there should now be a line showing
   the staged MARC record matches biblio
10) Note the "View"-text in the "Diff"-column
11) Apply patch
12) Install a language, view the same batch in the
    Manage staged MARC records -page in that language
13) The "View" should show up correctly, and if the
    msgid "View" was translated in the xx-YY-staff-prog.po,
    should show up in the correct language
Comment 2 Jonathan Druart 2018-02-27 16:58:28 UTC
Created attachment 72278 [details] [review]
Bug 20301: Allow translating "View" in manage MARC import

When looking at the table showing the staged MARC records, the "View"
text in the Diff-column is not translatable. Make it so.

Test plan:

1) Go to Home -> Tools -> Stage MARC records for import
2) Select eg. t/db_dependent/www/data/marc21record.mrc and upload the file
3) Click on Stage for import
   -> Manage staged records
   -> Import this batch into the catalog
4) Wait for zebra to reindex, or trigger it yourself by
   running rebuild_zebra.pl -a -b -r
5) Go to Home -> Tools -> Stage MARC records for import
6) Select the same file as in part 2 and upload the file
7) Change the Record matching rule to ISBN (020$a)
8) Click on Stage for import
   -> Manage staged records
9) In the table below, there should now be a line showing
   the staged MARC record matches biblio
10) Note the "View"-text in the "Diff"-column
11) Apply patch
12) Install a language, view the same batch in the
    Manage staged MARC records -page in that language
13) The "View" should show up correctly, and if the
    msgid "View" was translated in the xx-YY-staff-prog.po,
    should show up in the correct language

Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Jonathan Druart 2018-02-27 16:58:56 UTC
Trivial, skipping QA.
Comment 4 Jonathan Druart 2018-02-27 19:00:43 UTC
Pushed to master for 18.05
Comment 5 Nick Clemens 2018-04-06 17:47:17 UTC
Awesome work all, backported to stable for 17.11.05