There are a few instances of div#toolbar which contain markup which isn't consistent with most other examples. This can cause problems with CSS styles.
Created attachment 72680 [details] [review] Bug 20372: Correct toolbar markup on some pages Differences in markup around some toolbars has the potential to create CSS styling problems. This patch changes the markup to be consistent with other instances of <div id="toolbar"></div> To test, apply the patch and view these pages: - Course reserves (main page) - Course reserves -> Course detail page - Reports -> Dictionary On each of these pages the toolbar should look correct.
Created attachment 72682 [details] [review] Bug 20372: Correct toolbar markup on some pages Differences in markup around some toolbars has the potential to create CSS styling problems. This patch changes the markup to be consistent with other instances of <div id="toolbar"></div> To test, apply the patch and view these pages: - Course reserves (main page) - Course reserves -> Course detail page - Reports -> Dictionary On each of these pages the toolbar should look correct.
Created attachment 72687 [details] [review] Bug 20372: Correct toolbar markup on some pages Differences in markup around some toolbars has the potential to create CSS styling problems. This patch changes the markup to be consistent with other instances of <div id="toolbar"></div> To test, apply the patch and view these pages: - Course reserves (main page) - Course reserves -> Course detail page - Reports -> Dictionary On each of these pages the toolbar should look correct. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Created attachment 72708 [details] [review] Bug 20372: Correct toolbar markup on some pages Differences in markup around some toolbars has the potential to create CSS styling problems. This patch changes the markup to be consistent with other instances of <div id="toolbar"></div> To test, apply the patch and view these pages: - Course reserves (main page) - Course reserves -> Course detail page - Reports -> Dictionary On each of these pages the toolbar should look correct. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all, backported to stable for 17.11.05
Pushed to 17.05.x for 17.05.11