Bug 20516 - Show patron's library in pending discharges table
Summary: Show patron's library in pending discharges table
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 20526
  Show dependency treegraph
 
Reported: 2018-04-04 12:08 UTC by Julian Maurice
Modified: 2018-04-05 17:55 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 20516: Show patron's library in pending discharges table (1.63 KB, patch)
2018-04-04 12:15 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 20516: Show patron's library in pending discharges table (1.68 KB, patch)
2018-04-04 15:00 UTC, M. Tompsett
Details | Diff | Splinter Review
Bug 20516: Show patron's library in pending discharges table (1.74 KB, patch)
2018-04-05 05:49 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2018-04-04 12:08:03 UTC

    
Comment 1 Julian Maurice 2018-04-04 12:15:24 UTC
Created attachment 73616 [details] [review]
Bug 20516: Show patron's library in pending discharges table

Test plan:
1. Enable syspref useDischarge
2. Login to OPAC and ask for a discharge (tab on the left)
3. Login to intranet, you should see a message about pending discharges,
   and a link. Click on the link.
4. Confirm that there is a 'Library' column in the table that is
   displaying the patron's library
Comment 2 M. Tompsett 2018-04-04 15:00:14 UTC
Created attachment 73644 [details] [review]
Bug 20516: Show patron's library in pending discharges table

Test plan:
1. Enable syspref useDischarge
2. Login to OPAC and ask for a discharge (tab on the left)
3. Login to intranet, you should see a message about pending discharges,
   and a link. Click on the link.
4. Confirm that there is a 'Library' column in the table that is
   displaying the patron's library

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 3 Katrin Fischer 2018-04-05 05:49:13 UTC
Created attachment 73672 [details] [review]
Bug 20516: Show patron's library in pending discharges table

Test plan:
1. Enable syspref useDischarge
2. Login to OPAC and ask for a discharge (tab on the left)
3. Login to intranet, you should see a message about pending discharges,
   and a link. Click on the link.
4. Confirm that there is a 'Library' column in the table that is
   displaying the patron's library

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2018-04-05 05:49:47 UTC
Is there a good rule about when it's better to use the class methods and when to use the TT plugin?
Comment 5 Julian Maurice 2018-04-05 07:42:16 UTC
(In reply to Katrin Fischer from comment #4)
> Is there a good rule about when it's better to use the class methods and
> when to use the TT plugin?

I suppose the TT plugin is only useful when all you have is a branchcode (not an object).
Comment 6 Jonathan Druart 2018-04-05 17:55:05 UTC
Pushed to master for 18.05, thanks to everybody involved!