Bug 20534 - Floating toolbar when editing vendors
Summary: Floating toolbar when editing vendors
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-06 09:06 UTC by Katrin Fischer
Modified: 2019-10-14 19:57 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 20534: Floating toolbar when editing vendors (3.13 KB, patch)
2018-04-06 12:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20534: Floating toolbar when editing vendors (3.18 KB, patch)
2018-04-06 14:47 UTC, Maksim Sen
Details | Diff | Splinter Review
Bug 20534: Floating toolbar when editing vendors (3.25 KB, patch)
2018-04-07 09:15 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 20534: Floating toolbar when editing vendors (3.00 KB, patch)
2018-09-24 12:37 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20534: Floating toolbar when editing vendors (3.10 KB, patch)
2018-09-24 12:43 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2018-04-06 09:06:41 UTC
When editing vendors with a lot of contacts, it would be nice to have a floating toolbar on top with the save button always visible.
Comment 1 Owen Leonard 2018-04-06 12:59:16 UTC Comment hidden (obsolete)
Comment 2 Maksim Sen 2018-04-06 14:47:58 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2018-04-07 09:15:33 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2018-04-07 09:16:07 UTC
I wish all my wishes came true so fast :) Works flawlessly, thx Owen!
Comment 5 Jonathan Druart 2018-04-09 19:10:42 UTC
Owen, same problem as we had on the patron edit page: https://screenshots.firefox.com/pvWlqcxFqUDgRU0L/pro.kohadev.org
Comment 6 Owen Leonard 2018-09-24 12:37:12 UTC Comment hidden (obsolete)
Comment 7 Owen Leonard 2018-09-24 12:43:39 UTC
Created attachment 79307 [details] [review]
Bug 20534: Floating toolbar when editing vendors

This patch moves the Save and Cancel controls on the vendor edit form
into a toolbar which sticks to the top of the screen as you scroll.

To test, apply the patch and Acquisitions -> New vendor.

- Confirm that as you scroll down the page, the toolbar with the Save
  and Cancel buttons sticks to the top of the screen.
- Test that the Save and Cancel buttons both work correctly.
- Perform the same tests when editing an existing vendor.

Signed-off-by: Maksim Sen <maksim.sen@inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Nick Clemens 2018-09-26 19:27:35 UTC
Awesome work all!

Pushed to master for 18.11
Comment 9 Martin Renvoize 2018-09-27 13:35:56 UTC
Enhancement, will not be backported to 18.05.x series.